Skip to content

Centralizes iOS and macOS values #170257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 14, 2025
Merged

Conversation

vashworth
Copy link
Contributor

@vashworth vashworth commented Jun 9, 2025

Centralizes iOS and macOS hard-coded values to a new enum called FlutterDarwinPlatform. This reduces hard-coded values throughout the tool. It also adds more attributes to the XcodeSdk enum for the same purpose.

Incremental change towards #166486.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels. a: desktop Running on desktop team-ios Owned by iOS platform team labels Jun 9, 2025
@vashworth vashworth marked this pull request as ready for review June 9, 2025 19:12
@vashworth vashworth requested a review from a team as a code owner June 9, 2025 19:12
@vashworth vashworth requested a review from bkonyi June 9, 2025 19:12
Copy link
Contributor

@bkonyi bkonyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall.

@vashworth vashworth added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 13, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Jun 13, 2025
Merged via the queue into flutter:master with commit e5d2130 Jun 14, 2025
143 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a: desktop Running on desktop platform-ios iOS applications specifically team-ios Owned by iOS platform team tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants