Skip to content

Roll Dart to 3.9.0-196.1.beta #170285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 10, 2025

Conversation

camsim99
Copy link
Contributor

@camsim99 camsim99 commented Jun 9, 2025

As part of steps for creating initial beta release, rolls Dart to 3.9.0-196.1.beta (dart-lang/sdk@b81ec2c).

Part of #170067.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard
Copy link

This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter.

Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed.

@github-actions github-actions bot added the engine flutter/engine repository. See also e: labels. label Jun 9, 2025
@itsjustkevin itsjustkevin self-requested a review June 9, 2025 20:56
Copy link
Contributor

@itsjustkevin itsjustkevin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@camsim99 camsim99 added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 9, 2025
Copy link
Contributor

auto-submit bot commented Jun 9, 2025

autosubmit label was removed for flutter/flutter/170285, because - The status or check suite Mac tool_integration_tests_5_5 has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 9, 2025
@camsim99
Copy link
Contributor Author

camsim99 commented Jun 9, 2025

Looks like there are some legit failures of the

[ 41.7s] stdout: [   +7 ms] Error: TypeError: Failed to fetch dynamically imported module: https://www.gstatic.com/flutter-canvaskit/9d85d135efe3e033f36658a3a2ee521140ea3ec9/chromium/canvaskit.js
[ 41.7s] stdout: 
[ 41.7s] stdout:            Dart stack trace:
[ 41.7s] stdout:            Non-error `null` thrown by JS does not have stack trace.
[ 41.7s] stdout:            Caught in Dart at:
[ 41.7s] stdout: 
[ 41.7s] stdout: 
[ 41.7s] stdout:            dart-sdk/lib/_internal/js_shared/lib/js_util_patch.dart 307:16                    callConstructor
...

variety, e.g. https://ci.chromium.org/ui/p/flutter/builders/try/Windows%20tool_integration_tests_7_9/10115/overview.

@camsim99
Copy link
Contributor Author

camsim99 commented Jun 9, 2025

The test that is failing (test/integration.shard/isolated/dart_data_asset_test.dart: dart data assets flutter run on chrome --debug) was actually removed in the master branch. Looks like a feature was submitted then reverted: #169273 then #170034. I also see it was reverted because of the test failing here.

Thinking we need to cherry-pick the revert.

auto-submit bot pushed a commit that referenced this pull request Jun 10, 2025
Cherry picks #170034, as I think this is causing failures in #170285, which bumps the Dart revision for the initial 3.34 beta release.

As of today, this initial beta cut includes #169273, which was reverted in #170034 because of the failing `test/integration.shard/isolated/dart_data_asset_test.dart` test that is failing in #170285.

FYI @mosuem
@matanlurey matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 10, 2025
@auto-submit auto-submit bot merged commit 8ed9edb into flutter:flutter-3.34-candidate.0 Jun 10, 2025
165 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App engine flutter/engine repository. See also e: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants