[Windows] Use ANGLE blit extension on GLES 2.0 #170298
Merged
+118
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
engine
loic-sharma
commented
Jun 9, 2025
| @@ -141,6 +141,10 @@ ProcTableGLES::ProcTableGLES( // NOLINT(google-readability-function-size) | |||
| DiscardFramebufferEXT.Reset(); | |||
| } | |||
|
|
|||
| if (!description_->HasExtension("GL_ANGLE_framebuffer_blit")) { | |||
| BlitFramebufferANGLE.Reset(); | |||
| } | |||
There was a problem hiding this comment.
I considered only loading this proc if we detect ANGLE, however, the GL_VERSION for the affected devices are 2.0.0, which causes DescriptionGLES::IsANGLE to return false.
loic-sharma
force-pushed
the
windows_angle_blit
branch
from
dedf917 to
6c061ea
Compare
loic-sharma
added
the
autosubmit
flutter-dashboard
bot
removed
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 13, 2025
This was referenced Jun 13, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 13, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates Flutter Windows to fall back to
glBlitFramebufferANGLEifglBlitFramebufferis not available. This makes Flutter Windows work on devices where ANGLE supports only GLES 2.0.Fixes: #169178
Background
ANGLE only implements GLES 2.0 on some Windows 10+ machines (1, 2).
Flutter Windows 3.27.4 and lower was using
glBlitFramebufferon GLES 2.0 devices, even though that requires GLES 3.0. This magically worked though, thanks to ANGLE.However in 3.29.0, Impeller was updated to not resolve GLES 3.0 procs on GLES 2.0: flutter/engine#56636. This caused Flutter Windows to crash on GLES 2.0 devices since it was calling
glBlitFramebuffer.Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.