Reland lazy path and object arenas #170303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
engine
…is for testing the CDN).
matanlurey
approved these changes
Jun 12, 2025
mdebbar
approved these changes
Jun 13, 2025
| await _runGalleryE2eWebTest('profile'); | ||
| await _runGalleryE2eWebTest('release'); | ||
|
|
||
| // await runShardRunnerIndexOfTotalSubshard(tests); |
There was a problem hiding this comment.
Is this intentionally commented out? If so, could you please add a comment explaining the reason?
There was a problem hiding this comment.
Doh, this was a mistake. Thanks for catching this.
eyebrowsoffire
added
the
autosubmit
flutter-dashboard
bot
removed
the
autosubmit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an attempt to reland #168996
There were some issues that cropped up in the
web_long_running_testshards. However, it turns out that these tests don't actually run in presubmit on any PR that has any engine changes, which is not ideal. I modified the long running tests to run in presubmit, but this had issues because apparently a big chunk of these integration tests actually are trying to download canvaskit from CDN. I changed almost all of the tests to use local canvaskit (which should make them more reliable and hermetic). There is one test whose job is to actually test the CDN itself, and I am leaving that disabled in presubmit for PRs that have engine changes (since the engine artifacts won't be uploaded to CDN yet) but the rest of them are all running and passing now.Also, I fixed the underlying issue that was exposed by the long running tests, which is that the CanvasKit path clipping stuff in the layer visitor needs to be aware of LazyPath.