Fix DropdownMenu does not apply opacity to the selected value when disabled #170336
+59
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
framework
…sabled Signed-off-by: huycozy <[email protected]>
huycozy
force-pushed
the
fix-dropdownmenu-opacity-selected-value-disabled-169942
branch
from
8fc8dd2 to
c57ae72
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #169942
Description
The bug is about the effectiveTextStyle being applied to the inner TextField inside DropdownMenu fails to reflect the disabled style based on the enabled property.
The fix for this is simply to check the
enabledproperty and override the TextField's TextStyle.Demo of the fix
before.mov
after.mov
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.