Posix: Use aot-snapshot if FLUTTER_TOOLS_USE_AOT_SNAPSHOT=1
#170488
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
I've added a flag, off by default, to use
aot-snapshotwhen compiling/runningflutter:@jonahwilliams mentioned that the compile cost would be higher, and he's right:
So, roughly twice as long to compile initially on my Macbook M1 Max laptop.
I'm considering letting others try it and give feedback, and if we like the behavior, we could do anything such as making it the default on
master, or deciding it's not worth it and reverting the behavior entirely.