licenses_cpp: Started writing the licenses file #170539
Merged
+332
−47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
engine
gaaclarke
changed the title
gaaclarke
force-pushed
the
licenses-write-file
branch
from
65ad748 to
a9937df
Compare
gaaclarke
commented
Jun 12, 2025
| @@ -137,13 +166,24 @@ std::vector<absl::Status> LicenseChecker::Run(std::string_view working_dir, | |||
| return errors; | |||
| } | |||
| } | |||
| auto package_emplace_result = | |||
| license_map.try_emplace(package, absl::flat_hash_set<std::string>()); | |||
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
gaaclarke
added
the
autosubmit
flutter-dashboard
bot
removed
the
autosubmit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This writes the licenses and associates them with packages. It has simple deduplication. This also adds linux ci tests. Writing the file adds about 7 seconds, now we are at 37s. Too much is getting written now though so that should come down once the output is corrected.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.