remove --start-paused flag by default and set useDwdsWebSocketConnect… #170612
Conversation
…ion in DWDS; also updated logic for adding middleware and generating loadindicator
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
github-actions
bot
added
the
tool
| @@ -1079,20 +1075,22 @@ class WebDevFS implements DevFS { | |||
| '// Service worker not loaded in run mode.', | |||
| ); | |||
| webAssetServer.writeFile('version.json', FlutterProject.current().getVersionInfo()); | |||
| final bool shouldEnabledLoadIndicator = | |||
There was a problem hiding this comment.
I believe this should be the same as shouldEnableMiddleware. As long as the injected client is there, we can use the loading indicator because that is what sends the event to turn it off.
| @@ -1079,20 +1075,22 @@ class WebDevFS implements DevFS { | |||
| '// Service worker not loaded in run mode.', | |||
| ); | |||
| webAssetServer.writeFile('version.json', FlutterProject.current().getVersionInfo()); | |||
| final bool shouldEnabledLoadIndicator = | |||
There was a problem hiding this comment.
nit: ShouldEnableLoadIndicator
| // we fall back to the default Chrome connection. | ||
| final bool useDwdsWebSocketConnection = | ||
| supportedWebDeviceIds.isEmpty || | ||
| !supportedWebDeviceIds.contains(globals.deviceManager?.specifiedDeviceId ?? 'chrome'); |
There was a problem hiding this comment.
nit: GoogleChromeDevice.kChromeDeviceId instead of chrome
Related to dart-lang/sdk#60289.
Sibling PR in DWDS: dart-lang/webdev#2629
This PR will need to be submitted before this one. The pubspec must be updated with a new release of DWDS after the changes are submitted