Skip to content

rename from announce to supportsAnnounce on engine #170618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

rename from announce to supportsAnnounce on engine #170618

wants to merge 5 commits into from

Conversation

ash2moon
Copy link
Contributor

@ash2moon ash2moon commented Jun 13, 2025 •
edited
Loading

Part of #165510

⤴️ Original PR: #169685
⤵️ Child PR: #168992

This is a renaming of the announce to supportsAnnounce. See more info in this comment thread: #168992 (comment)

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added engine flutter/engine repository. See also e: labels. a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) platform-web Web applications specifically labels Jun 13, 2025
@ash2moon ash2moon mentioned this pull request Jun 13, 2025
Open
9 tasks
@ash2moon ash2moon requested review from a team, reidbaker and chunhtai June 13, 2025 22:16
reidbaker
reidbaker reviewed Jun 16, 2025
View reviewed changes
loic-sharma
loic-sharma reviewed Jun 16, 2025
View reviewed changes
@github-actions github-actions bot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. labels Jun 17, 2025
@ash2moon ash2moon requested review from a team and reidbaker June 17, 2025 23:01
chunhtai
chunhtai reviewed Jun 18, 2025
View reviewed changes
engine/src/flutter/lib/ui/window.dart
/// Whether accessibility announcements (like [SemanticsService.announce])
/// are supported on the current platform.
/// Whether the platform supports accessibility announcement API.
/// i.e. [SemanticsService.announce]. Some platforms do not
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A new line between first and second paragraph

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also the first paragraph should be
Whether the platform supports accessibility announcement API, i.e. [SemanticsService.announce].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loic-sharma loic-sharma loic-sharma left review comments

@chunhtai chunhtai chunhtai left review comments

@reidbaker reidbaker Awaiting requested review from reidbaker

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: tests "flutter test", flutter_test, or one of our tests engine flutter/engine repository. See also e: labels. framework flutter/packages/flutter repository. See also f: labels. platform-web Web applications specifically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ash2moon @loic-sharma @reidbaker @chunhtai