Skip to content

Service Health Status in Endpoints Controller Logs #4616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Service Health Status in Endpoints Controller Logs #4616

wants to merge 2 commits into from

Conversation

Ranjandas
Copy link
Contributor

@Ranjandas Ranjandas commented Jun 10, 2025 •
edited
Loading

Changes proposed in this PR

This PR includes the health status of the service being registered/updated by the endpoints controller.

This helps identify the service health state transitions, which are currently impossible and impact the ability to troubleshoot issues.

How I've tested this PR

  • Created a custom binary and used it in a Kubernetes cluster. Updates the logging to look like the below. Notice the health field in the logging.
INFO    controller.endpoints    retrieved       {"name": "nginx", "ns": "default"}
INFO    controller.endpoints    registering service with Consul {"name": "nginx", "id": "nginx-nginx", "health": "critical"}
INFO    controller.endpoints    adding manual ip to virtual ip table in Consul  {"name": "nginx", "id": ""}
INFO    controller.endpoints    registering proxy service with Consul   {"name": "nginx-sidecar-proxy", "id": "nginx-nginx-sidecar-proxy", "health": "critical"}
INFO    controller.endpoints    retrieved       {"name": "nginx", "ns": "default"}
INFO    controller.endpoints    registering service with Consul {"name": "nginx", "id": "nginx-nginx", "health": "passing"}
INFO    controller.endpoints    adding manual ip to virtual ip table in Consul  {"name": "nginx", "id": ""}
INFO    controller.endpoints    registering proxy service with Consul   {"name": "nginx-sidecar-proxy", "id": "nginx-nginx-sidecar-proxy", "health": "passing"}

Checklist

@Ranjandas
Service Health Status in Endpoints Controller Logs
3fa21a7 
This PR includes the health status of the service being registered/updated by the endpoints controller.

This helps in identifying the service health state transitions, which is currently not possible and impacts the ability to troubleshoot issues.
@Ranjandas Ranjandas requested a review from a team as a code owner June 10, 2025 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Ranjandas