Skip to content

[VAULT-34737] UI: move the dateTimeLocal block in FormField under the HDS block #30939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: VAULT-34671/formfield-migrate-boolean_VAULT-34798
Choose a base branch
from

Conversation

didoo
Copy link
Collaborator

@didoo didoo commented Jun 11, 2025

Important

⚠️ Based off #30771 to minimize conflicts - Don't merge until that PR is merged in main

Description

What does this PR do?

  • updated logic in isHdsFormField of FormField to include the editType === 'dateTimeLocal' use cases
  • moved template logic for editType === 'dateTimeLocal' in FormField under the isHdsField block

Jira ticket: https://hashicorp.atlassian.net/browse/VAULT-34737

Screenshots

Before:
screenshot_5046
screenshot_5047
screenshot_5048

After:
screenshot_5044
screenshot_5045
screenshot_5049

Note: the second datetime input is not using the <FormField> but a normal <Input> element so it's not been automatically migrated: https://github.com/hashicorp/vault/blob/main/ui/lib/config-ui/addon/components/messages/message-expiration-date-form.hbs#L44-L51

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@didoo didoo requested a review from dchyun June 11, 2025 14:29
Copy link

github-actions bot commented Jun 11, 2025

CI Results:
All Go tests succeeded! ✅

@drivera258 drivera258 added hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed ui and removed ui hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed labels Jun 11, 2025
@didoo didoo added this to the 1.21.0-rc milestone Jun 11, 2025
@didoo didoo added ui pr/no-changelog hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed hds-service HDS Service labels Jun 11, 2025
@didoo didoo marked this pull request as ready for review June 11, 2025 15:56
@didoo didoo requested a review from a team as a code owner June 11, 2025 15:56
Copy link

Build Results:
All builds succeeded! ✅

@didoo didoo force-pushed the VAULT-34671/formfield-migrate-datetime-local_VAULT-34737 branch from b1713c9 to e949eeb Compare June 12, 2025 08:30
@didoo didoo requested a review from a team June 12, 2025 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed hds-service HDS Service pr/no-changelog ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants