Write empty 200 response for failed upgrade #107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #107 +/- ##
=======================================
Coverage 80.35% 80.35%
=======================================
Files 6 6
Lines 397 397
=======================================
Hits 319 319
Misses 78 78 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Joannis
reviewed
Jun 1, 2025
| do { | ||
| try await asyncChannel.executeThenClose { _, outbound in | ||
| let headers: HTTPFields = [ | ||
| .connection: "close", | ||
| .contentLength: "0", | ||
| ] | ||
| let head = HTTPResponse( | ||
| status: .methodNotAllowed, | ||
| status: .ok, |
There was a problem hiding this comment.
Isn't this more of a 500 / internalServerError?
There was a problem hiding this comment.
It's not a 5xx as it isn't a server error. It is caused by the shouldUpgrade failing, which is client error. But the standard for an upgrading failing is 200. A successful upgrade returns a 101.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason I was returning a 405 (Method Not Allowed) which doesn't make sense.
Looking around on the web it seems an empty 200 is the standard response for a failed upgrade