Skip to content

Fix validation of NodeSelectorTerm in pod.nodeAffinity #126327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix validation of NodeSelectorTerm in pod.nodeAffinity #126327

wants to merge 1 commit into from

Conversation

astraw99
Copy link
Member

@astraw99 astraw99 commented Jul 24, 2024 •
edited
Loading

What type of PR is this?

/kind bug

What this PR does / why we need it:

To add validation of NodeSelectorTerm in pod.nodeAffinity.

Which issue(s) this PR fixes:

Fixes #126325

Special notes for your reviewer:

Also added some test cases covering this scenario.

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jul 24, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: astraw99
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added sig/apps Categorizes an issue or PR as relevant to SIG Apps. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 24, 2024
googs1025
googs1025 reviewed Jul 24, 2024
View reviewed changes
@astraw99 astraw99 force-pushed the fix-node-affinity-validation branch from 7a9b434 to 5737a07 Compare July 24, 2024 13:55
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 24, 2024
googs1025
googs1025 reviewed Jul 31, 2024
View reviewed changes
@k8s-ci-robot
Copy link
Contributor

@googs1025: The label(s) sig/api cannot be applied, because the repository doesn't have them.

In response to this:

/sig api

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@googs1025
Copy link
Member

/sig apps
/sig api-machinery

@k8s-ci-robot k8s-ci-robot added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Aug 2, 2024
@seans3
Copy link
Contributor

seans3 commented Aug 2, 2024

/triage accepted
/assign @Jefftree
Jeff, can you take a look when you get a chance. Thanks :)

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 2, 2024
@googs1025
Copy link
Member

friendly ping /PTAL @Jefftree :)

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 29, 2024
@astraw99
Copy link
Member Author

astraw99 commented Dec 1, 2024

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 1, 2024
@astraw99
Copy link
Member Author

/ping @Jefftree
PTAL thanks.

@Jefftree
Copy link
Member

This looks good to me though I'm not sure it needs ratcheting since it is a core type.

/assign @thockin

@thockin
Copy link
Member

thockin commented Mar 12, 2025 •
edited
Loading

I think this has to be ratcheted and more than that it has to be compat-versioned.

That means adding a gate (OK to start beta). If the gate is not set, use legacy behavior. If the gate is set then apply the rathet: If this is create, be strict. If this is an update and the old value was invalid, allow it to remain invalid, but if the olf value was valid, be strict.

Beta in 33 (or 34 at this stage), GA in N+1, remove gate in N+4.

@Jefftree is that what you were thinking, too?

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 10, 2025
@astraw99
Copy link
Member Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@googs1025 googs1025 googs1025 left review comments

@pwittrock pwittrock Awaiting requested review from pwittrock

@yujuhong yujuhong Awaiting requested review from yujuhong

Assignees

@thockin thockin

@Jefftree Jefftree

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Apps
Status: Needs Triage
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Empty NodeSelectorTerm is confusing in pod.nodeAffinity
7 participants
@astraw99 @k8s-ci-robot @googs1025 @seans3 @k8s-triage-robot @Jefftree @thockin