Skip to content

DRA ResourceSlice mixins #131357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

DRA ResourceSlice mixins #131357

wants to merge 7 commits into from

Conversation

mortent
Copy link
Member

@mortent mortent commented Apr 17, 2025 •
edited
Loading

What type of PR is this?

/kind feature
/kind api-change

What this PR does / why we need it:

This implements kubernetes/enhancements#5238

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Scheduler perf tests are not in this PR since the tests are pinned at the 1.33 emulated version, ref #131973 (comment)

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot
Copy link
Contributor

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 17, 2025
@k8s-ci-robot
Copy link
Contributor

Please note that we're already in Test Freeze for the release-1.33 branch. This means every merged PR will be automatically fast-forwarded via the periodic ci-fast-forward job to the release branch of the upcoming v1.33.0 release.

Fast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Thu Apr 17 13:31:58 UTC 2025.

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Apr 17, 2025
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Apr 17, 2025
@k8s-ci-robot k8s-ci-robot requested review from bart0sh and deads2k April 17, 2025 17:46
@k8s-ci-robot k8s-ci-robot added area/code-generation sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/node Categorizes an issue or PR as relevant to SIG Node. wg/device-management Categorizes an issue or PR as relevant to WG Device Management. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 17, 2025
@mortent mortent force-pushed the DRAResourceSliceMixins branch from 999e261 to f8bc05f Compare April 17, 2025 22:49
@bg-chun bg-chun mentioned this pull request Apr 18, 2025
Merged
@mortent mortent force-pushed the DRAResourceSliceMixins branch from f8bc05f to 4b0ebe3 Compare April 18, 2025 14:35
jackfrancis
jackfrancis reviewed Apr 18, 2025
View reviewed changes
pkg/features/kube_features.go Outdated
@@ -1162,6 +1169,10 @@ var defaultVersionedKubernetesFeatureGates = map[featuregate.Feature]featuregate
{Version: version.MustParse("1.33"), Default: true, PreRelease: featuregate.Beta},
},

DRAResourceSliceMixins: {
{Version: version.MustParse("1.33"), Default: false, PreRelease: featuregate.Alpha}, // TODO(mortent): Update to 1.34 before merge.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be 1.34

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(just saw TODO comment, you're on top of it!)

@bart0sh bart0sh moved this from Triage to Work in progress in SIG Node: code and documentation PRs Apr 19, 2025
@mortent mortent force-pushed the DRAResourceSliceMixins branch 2 times, most recently from d50a8b3 to be0bc55 Compare May 6, 2025 00:49
@mortent mortent force-pushed the DRAResourceSliceMixins branch 2 times, most recently from db49121 to 63e51ae Compare May 29, 2025 02:25
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mortent
Once this PR has been reviewed and has the lgtm label, please assign deads2k, kerthcet, pohly for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mortent mortent changed the title [WIP] DRA ResourceSlice mixins DRA ResourceSlice mixins May 29, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 29, 2025
@k8s-triage-robot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@mortent mortent mentioned this pull request May 30, 2025
Merged
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 31, 2025
@mortent mortent force-pushed the DRAResourceSliceMixins branch from 63e51ae to defdad6 Compare June 1, 2025 15:30
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 1, 2025
@mortent mortent force-pushed the DRAResourceSliceMixins branch from defdad6 to 5c494bc Compare June 1, 2025 21:40
@mortent mortent force-pushed the DRAResourceSliceMixins branch from 5c494bc to 78b6b31 Compare June 2, 2025 16:07
@mortent mortent force-pushed the DRAResourceSliceMixins branch from 78b6b31 to 4267c23 Compare June 2, 2025 17:22
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jun 2, 2025 •
edited
Loading

@mortent: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-linter-hints 4267c23 link false /test pull-kubernetes-linter-hints

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@mortent
Copy link
Member Author

mortent commented Jun 2, 2025

/test pull-kubernetes-e2e-kind-ipv6
/test pull-kubernetes-integration

mortent
mortent commented Jun 2, 2025
View reviewed changes
staging/src/k8s.io/dynamic-resource-allocation/api/types.go
type CounterSet struct {
Name UniqueString
Counters map[string]Counter
MixinRefs []UniqueString
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm renaming the field here to prevent the code generation from trying to automatically convert this field. It seems like it thinks it can automatically convert between slice of string and slice of uniquestring, but the result doesn't work.

@mortent
Copy link
Member Author

mortent commented Jun 2, 2025

This is ready for review.

/assign @johnbelamaric @pohly

@cici37
Copy link
Contributor

cici37 commented Jun 10, 2025

/remove-sig api-machinery

@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Jun 10, 2025
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackfrancis jackfrancis jackfrancis left review comments

@bart0sh bart0sh Awaiting requested review from bart0sh

@deads2k deads2k Awaiting requested review from deads2k

Assignees

@pohly pohly

@johnbelamaric johnbelamaric

Labels
area/code-generation area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. wg/device-management Categorizes an issue or PR as relevant to WG Device Management.
Projects
Dynamic Resource Allocation
Status: 🏗 In progress
SIG Node CI/Test Board
Status: Archive-it
SIG Node: code and documentation PRs
Status: Work in progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@mortent @k8s-ci-robot @k8s-triage-robot @cici37 @jackfrancis @pohly @johnbelamaric