test: validate that watchers close without error #131505
Open
+405
−146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
karlkfi
force-pushed
the
karl-watcher-closed-tests
branch
2 times, most recently
from
b35e574 to
c055de6
Compare
|
/assign @wojtek-t |
|
/cc @siyuanfoundation @serathius /triage accepted |
k8s-ci-robot
added
triage/accepted
karlkfi
changed the title
k8s-ci-robot
added
the
do-not-merge/work-in-progress
|
Blocking this on #131457, which covers closing response body a bit more cleanly and robustly. This can be rebased later to cover channel close and draining |
k8s-ci-robot
added
the
needs-rebase
karlkfi
force-pushed
the
karl-watcher-closed-tests
branch
from
c055de6 to
2a05e10
Compare
k8s-ci-robot
removed
the
needs-rebase
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: karlkfi The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
karlkfi
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
/remove-kind flake This doesn't fix flakes, but does identify one as TODO. |
k8s-ci-robot
removed
the
kind/flake
- Add channel test helpers to k8s.io/client-go/util/testing
- Use the new channel test helpers in the client and server watch
tests to validate that the result channels closes without error
when the client stops the watcher.
- Use the new channel test helpers in the client watcher decoder
tests to validate that encoded watch events can be decoded and
that the decoder errors with EOF when stopped asynchronously.
These new tests uncovered existing errors (added TODOs):
1. The watch client doesn't close the response body when it
encounters a NegotiateError.
2. The watch client sometimes sends a decode error on the result
channel after the client watcher has been stopped.
3. StreamWatcher.receive uses %v instead of %w when wrapping errors.
karlkfi
force-pushed
the
karl-watcher-closed-tests
branch
from
2a05e10 to
f17abda
Compare
|
tests passed. ready for review. |
|
@wojtek-t can you take a look at this? Do you need me to break it up? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
These new tests uncovered existing errors (added TODOs):
Does this PR introduce a user-facing change?
Dependencies