Skip to content

Refactor PV mount option validation into core validation #131546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Refactor PV mount option validation into core validation #131546

wants to merge 1 commit into from

Conversation

carlory
Copy link
Member

@carlory carlory commented Apr 30, 2025

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

  1. Move annotation keys to the pkg/apis/core/annotation_key_constants.go
  2. Rename volume.ValidatePersistentVolume and move it into core.ValidatePersistentVolume ( it won't cause this issue kubectl 1.6.0-beta.1 is twice the size of kubectl-1.5.3 #42573)

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Apr 30, 2025
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Apr 30, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: carlory
Once this PR has been reviewed and has the lgtm label, please assign msau42 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from cici37 and dims April 30, 2025 08:53
@k8s-ci-robot k8s-ci-robot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 30, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in SIG Apps Apr 30, 2025
@carlory
Copy link
Member Author

carlory commented Apr 30, 2025

/cc @gnufied

@k8s-ci-robot k8s-ci-robot requested a review from gnufied April 30, 2025 08:56
@k8s-triage-robot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@carlory
Copy link
Member Author

carlory commented Apr 30, 2025

/test pull-kubernetes-integration

@gnufied
Copy link
Member

gnufied commented May 1, 2025

/assign

gnufied
gnufied suggested changes May 1, 2025
View reviewed changes
Copy link
Member

@gnufied gnufied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Some minor nit.

@github-project-automation github-project-automation bot moved this from Needs Triage to In Progress in SIG Apps May 1, 2025
@carlory
Copy link
Member Author

carlory commented May 9, 2025

/cc @gnufied @msau42

@k8s-ci-robot k8s-ci-robot requested review from gnufied and msau42 May 9, 2025 02:12
@carlory
Copy link
Member Author

carlory commented Jun 11, 2025

kindly ping @gnufied @msau42

@gnufied
Copy link
Member

gnufied commented Jun 11, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 11, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: fe1bd2dd6066d1904d55cbe2784e17d4587126ec

@carlory
Copy link
Member Author

carlory commented Jun 12, 2025

/assign @msau42
for approval

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cici37 cici37 Awaiting requested review from cici37

@dims dims Awaiting requested review from dims

@gnufied gnufied Awaiting requested review from gnufied

@msau42 msau42 Awaiting requested review from msau42

Assignees

@gnufied gnufied

@msau42 msau42

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
SIG Apps
Status: In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@carlory @k8s-ci-robot @k8s-triage-robot @gnufied @msau42