Skip to content

client-go: call out WithContext inconsistency #131670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 10, 2025
Merged

client-go: call out WithContext inconsistency #131670

merged 1 commit into from
Jun 10, 2025

Conversation

pohly
Copy link
Contributor

@pohly pohly commented May 8, 2025

What type of PR is this?

/kind documentation

What this PR does / why we need it:

This raises awareness so that developers hopefully get it right without having to learn about it from compile errors. It also explains that creating a PR to fix the naming is not desired.

Which issue(s) this PR fixes:

Related-to: #131529 (comment)

Does this PR introduce a user-facing change?

NONE

/cc @wzshiming @liggitt

@pohly
client-go: call out WithContext inconsistency
f40892f 
This raises awareness so that developers hopefully get it right without having to
learn about it from compile errors. It also explains that creating a PR to
fix the naming is not desired.
@k8s-ci-robot k8s-ci-robot requested review from liggitt and wzshiming May 8, 2025 12:33
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 8, 2025
@pohly pohly mentioned this pull request May 8, 2025
Closed
@aaron-prindle
Copy link
Contributor

/triage approve

@k8s-ci-robot
Copy link
Contributor

@aaron-prindle: The label(s) triage/approve cannot be applied, because the repository doesn't have them.

In response to this:

/triage approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@aaron-prindle
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 8, 2025
wzshiming
wzshiming approved these changes May 9, 2025
View reviewed changes
Copy link
Member

@wzshiming wzshiming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 9, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6ccbcf96cb7a01b81c32ad72188b788b355b0584

@pohly
Copy link
Contributor Author

pohly commented May 30, 2025

/assign @liggitt

@liggitt liggitt added this to the v1.34 milestone Jun 10, 2025
@liggitt
Copy link
Member

liggitt commented Jun 10, 2025

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chansuke, liggitt, pohly, wzshiming

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 10, 2025
@k8s-ci-robot k8s-ci-robot merged commit 3d699ce into kubernetes:master Jun 10, 2025
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chansuke chansuke chansuke approved these changes

@wzshiming wzshiming wzshiming approved these changes

@liggitt liggitt Awaiting requested review from liggitt

Assignees

@liggitt liggitt

@wzshiming wzshiming

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.34
Development

Successfully merging this pull request may close these issues.
6 participants
@pohly @aaron-prindle @k8s-ci-robot @liggitt @chansuke @wzshiming