disable terminatingReplicas reconciliation in ReplicationController #131822
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/bug
k8s-ci-robot
added
release-note
|
/priority important-soon |
k8s-ci-robot
added
priority/important-soon
atiratree
commented
May 16, 2025
|
/assign @liggitt |
atiratree
force-pushed
the
replicationcontroller-terminating-replicas
branch
from
5f0476a to
5d35202
Compare
chansuke
reviewed
May 16, 2025
atiratree
force-pushed
the
replicationcontroller-terminating-replicas
branch
from
5d35202 to
c9a4782
Compare
liggitt
reviewed
May 20, 2025
pkg/apis/core/v1/conversion_test.go
Outdated
| @@ -319,6 +319,8 @@ func TestReplicationControllerConversion(t *testing.T) { | |||
| t.Errorf("can't convert RC to RS: %v", err) | |||
| continue | |||
| } | |||
| // fill in new fields that should not exist in a ReplicationController, but do exist in a ReplicaSet | |||
| apiObjectFuzzer.FillNoCustom(&rs.Status.TerminatingReplicas) | |||
There was a problem hiding this comment.
I'm not sure what this is demonstrating or catching ... the issue wasn't in conversion, it was in controller logic
There was a problem hiding this comment.
I was trying to improve the fuzzing that you have mentioned in #128546 (comment) and this was the only improvement that I could think of.
Ok, never mind, I have removed this commit.
liggitt
reviewed
May 20, 2025
atiratree
force-pushed
the
replicationcontroller-terminating-replicas
branch
from
c9a4782 to
b7d16fe
Compare
k8s-ci-robot
added
the
approved
|
flake |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: faf37cb98edc335354d560ad5654e815986fc6cf
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: atiratree, liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
disable terminatingReplicas reconciliation in ReplicationController
Which issue(s) this PR fixes:
Fixes #131821
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: