Skip to content

Promote automatic_reloads of encryption config metrics to BETA #131824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Promote automatic_reloads of encryption config metrics to BETA #131824

wants to merge 1 commit into from

Conversation

aramase
Copy link
Member

@aramase aramase commented May 16, 2025

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Promote apiserever_encryption_config_controller_automatic_reloads_total and apiserver_encryption_config_controller_automatic_reload_last_timestamp_seconds metrics to BETA. The feature has been GA since 1.29.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Promote `apiserever_encryption_config_controller_automatic_reloads_total` and `apiserver_encryption_config_controller_automatic_reload_last_timestamp_seconds` metrics to BETA.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[KEP]: https://github.com/kubernetes/enhancements/tree/master/keps/sig-auth/3299-kms-v2-improvements

/triage accepted
/sig auth
/priority important-soon

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. triage/accepted Indicates an issue or PR is ready to be actively worked on. sig/auth Categorizes an issue or PR as relevant to SIG Auth. labels May 16, 2025
@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 16, 2025
@aramase
Copy link
Member Author

aramase commented May 16, 2025

/assign enj

@k8s-ci-robot k8s-ci-robot requested review from enj and logicalhan May 16, 2025 18:45
@k8s-ci-robot k8s-ci-robot added area/apiserver area/stable-metrics Issues or PRs involving stable metrics sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. labels May 16, 2025
@k8s-triage-robot
Copy link

This PR may require stable metrics review.

Stable metrics are guaranteed to not change. Please review the documentation for the requirements and lifecycle of stable metrics and ensure that your metrics meet these guidelines.

@aramase aramase force-pushed the aramase/f/kms_metrics_beta branch from a8edbd7 to b491f97 Compare May 16, 2025 19:23
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aramase
Once this PR has been reviewed and has the lgtm label, please ask for approval from enj and additionally assign serathius for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@enj enj moved this to Needs Triage in SIG Auth May 17, 2025
@ibihim ibihim moved this from Needs Triage to In Review in SIG Auth May 19, 2025
dgrisonnet
dgrisonnet reviewed May 23, 2025
View reviewed changes
test/instrumentation/testdata/stable-metrics-list.yaml
type: Gauge
stabilityLevel: BETA
labels:
- apiserver_id_hash
Copy link
Member

@dgrisonnet dgrisonnet May 23, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the apiserver_id_hash meant to identify which apiserver instance this metrics corresponds to?

Usually we expect the monitoring platform to be able to identify where the metric is coming from. For example via the kubernetes service discovery in Prometheus you can tell from which node/pod/container a metric is from.

The problem with a custom identifier is that you won't be able to correlate existing apiserver metrics that don't have this label with it. So generally we leave that to the monitoring system. Would that make sense in this case?

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 12, 2025
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgrisonnet dgrisonnet dgrisonnet left review comments

@enj enj Awaiting requested review from enj

@logicalhan logicalhan Awaiting requested review from logicalhan

Assignees

@enj enj

Labels
area/apiserver area/stable-metrics Issues or PRs involving stable metrics cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Auth
Status: In Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aramase @k8s-triage-robot @k8s-ci-robot @dgrisonnet @enj