Skip to content

Remove deprecated default toleration seconds flags in kube-apiserver and migrate to versioned config #131955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Remove deprecated default toleration seconds flags in kube-apiserver and migrate to versioned config #131955

wants to merge 3 commits into from

Conversation

togettoyou
Copy link
Contributor

What type of PR is this?

/kind bug

What this PR does / why we need it:

Remove the --default-not-ready-toleration-seconds and --default-unreachable-toleration-seconds flags from kube-apiserver.

The DefaultTolerationSeconds admission plugin is now configured through a versioned configuration file. To enable the plugin and provide configuration, use the following setup:

AdmissionConfiguration (apiserver config):

apiVersion: apiserver.config.k8s.io/v1
kind: AdmissionConfiguration
plugins:
  - name: DefaultTolerationSeconds
    path: dtsconfig.yaml

Plugin configuration file (dtsconfig.yaml):

apiVersion: defaulttolerationseconds.admission.k8s.io/v1alpha1
kind: Configuration
defaultTolerationSecondsConfig:
  notReadyTolerationSeconds: 300
  unreachableTolerationSeconds: 300

Which issue(s) this PR fixes:

Fixes #55284

Special notes for your reviewer:

Does this PR introduce a user-facing change?

kube-apiserver: the deprecated flags `--default-not-ready-toleration-seconds` and `--default-unreachable-toleration-seconds` have been removed. Use versioned configuration for the DefaultTolerationSeconds admission plugin instead.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 25, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @togettoyou. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added area/apiserver area/test sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 25, 2025
@k8s-ci-robot k8s-ci-robot requested review from aojea and odinuge May 25, 2025 08:36
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: togettoyou
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seans3
Copy link
Contributor

seans3 commented May 27, 2025

/ok-to-test
/triage accepted

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 27, 2025
@togettoyou
Copy link
Contributor Author

/retest

@togettoyou
Copy link
Contributor Author

/cc @liggitt

@k8s-ci-robot k8s-ci-robot requested a review from liggitt May 28, 2025 09:34
@liggitt
Copy link
Member

liggitt commented Jun 11, 2025

see the comment at #55284 (comment) for a possible much smaller first step to eliminate the global flag registration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aojea aojea Awaiting requested review from aojea

@odinuge odinuge Awaiting requested review from odinuge

@liggitt liggitt Awaiting requested review from liggitt

Assignees
No one assigned
Labels
area/apiserver area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DefaultTolerationSeconds admission plugin flags pollute all commands
4 participants
@togettoyou @k8s-ci-robot @seans3 @liggitt