This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@pohly: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

/remove-sig api-machinery

Anyone who enabled DRA stuff while in v1alpha3, and upgraded their cluster since then without doing any storage migrations needs to run a storage migration on DRA types before upgrading to 1.34 which includes this PR. That's fair game since this is an alpha version, but should be release noted.

/lgtm
/approve

one question about the test file, and please update the release note

LGTM label has been added.

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, pohly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

needs to run a storage migration on DRA types before upgrading to 1.34

Do we have some standard instructions for doing this?

needs to run a storage migration on DRA types before upgrading to 1.34

Do we have some standard instructions for doing this?

Hmm... I thought we did, but all I'm finding is https://kubernetes.io/docs/tasks/manage-kubernetes-objects/storage-version-migration/ which is the alpha controller-driven feature.

Conceptually, a no-op patch of every instance would accomplish what we need.

Something like this does it, but is gorpy / weird to document as the "official" way to do a manual storage migration:

kubectl get resourceslices,resourceclaims,deviceclasses,resourceclaimtemplates,devicetaintrules -A -o json \
   | jq -r '.items[] | "-n \(.metadata.namespace) \(.kind)s/\(.metadata.name)"' \
   | xargs -L 1 kubectl patch  --type=merge --patch='{}'

needs to run a storage migration on DRA types before upgrading to 1.34

Do we have some standard instructions for doing this?

Hmm... I thought we did, but all I'm finding is https://kubernetes.io/docs/tasks/manage-kubernetes-objects/storage-version-migration/ which is the alpha controller-driven feature.

cc @deads2k for visibility ... probably should have storage migration procedures documented

Considering that this only affects users of Kubernetes < 1.32 and only if they enabled an alpha feature, I think we can go for "delete all of these types before an update".

/release-note-edit

DRA API: resource.k8s.io/v1alpha3 now only contains DeviceTaintRule. All other types got removed because they became obsolete when introducing the v1beta1 API in 1.32.
ACTION REQUIRED: before updating a cluster where resourceclaims, resourceclaimtemplates, deviceclasses, or resourceslices might have been stored using Kubernetes < 1.32, delete all of those resources before updating and recreate them as needed while running Kubernetes >= 1.32.

/hold cancel