Skip to content

[KEP-4369]: Graduate RelaxedEnvironmentVariableValidation to GA #132054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 10, 2025
Merged

[KEP-4369]: Graduate RelaxedEnvironmentVariableValidation to GA #132054

merged 3 commits into from
Jun 10, 2025

Conversation

HirazawaUi
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Promote the RelaxedEnvironmentVariableValidation feature gate to GA and lock it in the default enabled state.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/tree/master/keps/sig-node/4369-allow-special-characters-environment-variable

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 2, 2025
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/test sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 2, 2025
@k8s-ci-robot k8s-ci-robot requested review from bart0sh and justinsb June 2, 2025 10:05
@HirazawaUi HirazawaUi force-pushed the promote-4369-to-ga branch from 1a39b1e to ef7638f Compare June 2, 2025 10:31
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/kubelet and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 2, 2025
kannon92
kannon92 reviewed Jun 3, 2025
View reviewed changes
@HirazawaUi HirazawaUi changed the title kubelet: Graduate RelaxedEnvironmentVariableValidation Feature gate to beta kubelet: Graduate RelaxedEnvironmentVariableValidation Feature gate to GA Jun 3, 2025
@HirazawaUi HirazawaUi force-pushed the promote-4369-to-ga branch from ef7638f to 98cc213 Compare June 3, 2025 00:58
@kannon92
Copy link
Contributor

kannon92 commented Jun 3, 2025

kubernetes/enhancements#4369 (comment)

/hold

/retitle [KEP-4369]: Graduate RelaxedEnvironmentVariableValidation to GA

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 3, 2025
@k8s-ci-robot k8s-ci-robot changed the title kubelet: Graduate RelaxedEnvironmentVariableValidation Feature gate to GA [KEP-4369]: Graduate RelaxedEnvironmentVariableValidation to GA Jun 3, 2025
@HirazawaUi HirazawaUi mentioned this pull request Jun 3, 2025
Open
21 tasks
@SergeyKanzhelev SergeyKanzhelev moved this from Triage to Archive-it in SIG Node CI/Test Board Jun 4, 2025
SergeyKanzhelev
SergeyKanzhelev reviewed Jun 6, 2025
View reviewed changes
SergeyKanzhelev
SergeyKanzhelev reviewed Jun 6, 2025
View reviewed changes
Copy link
Member

@SergeyKanzhelev SergeyKanzhelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update all the types.go to remove the mention of this feature gate. Since it is GA now, no need to mention that it used to exist

@HirazawaUi HirazawaUi force-pushed the promote-4369-to-ga branch from 5e1b7e5 to 3799adf Compare June 8, 2025 03:58
@HirazawaUi HirazawaUi force-pushed the promote-4369-to-ga branch 2 times, most recently from e239624 to 8cdb2cd Compare June 8, 2025 07:24
@k8s-ci-robot k8s-ci-robot added area/conformance Issues or PRs related to kubernetes conformance tests sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. labels Jun 8, 2025
@thockin
Copy link
Member

thockin commented Jun 8, 2025

/approve for API
/hold for review

@SergeyKanzhelev
Copy link
Member

@HirazawaUi can you please upgrade to Conformance as a follow up PR instead of including here. Since some tests are modified, let it run for a few days.

@HirazawaUi HirazawaUi force-pushed the promote-4369-to-ga branch from 8cdb2cd to ef2c18a Compare June 10, 2025 16:03
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HirazawaUi, SergeyKanzhelev, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 10, 2025
@HirazawaUi
Copy link
Contributor Author

can you please upgrade to Conformance as a follow up PR instead of including here. Since some tests are modified, let it run for a few days.

Thanks for reminding me. I didn't understand your meaning correctly before. I have rolled back the code.

@SergeyKanzhelev
Copy link
Member

/lgtm
/unhold

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jun 10, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: cb154984696d9075a14cb9c55b645bed5b5922a6

@SergeyKanzhelev
Copy link
Member

@HirazawaUi I would appreciate if you can send the conformance promotion PR soon. Please ensure a green run in testgrid and link it from the PR you will create.

@k8s-ci-robot
Copy link
Contributor

@HirazawaUi: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-unit-windows-master ef2c18a link false /test pull-kubernetes-unit-windows-master

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@HirazawaUi
Copy link
Contributor Author

HirazawaUi commented Jun 10, 2025 •
edited
Loading

I would appreciate if you can send the conformance promotion PR soon. Please ensure a green run in testgrid and link it from the PR you will create.

Okay, I will do that tomorrow. Let's wait for this PR to get merged first :)

@k8s-triage-robot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@bart0sh
Copy link
Contributor

bart0sh commented Jun 10, 2025

/retest

@bart0sh bart0sh moved this from Triage to Needs Approver in SIG Node: code and documentation PRs Jun 10, 2025
@k8s-ci-robot k8s-ci-robot merged commit 4db16ed into kubernetes:master Jun 10, 2025
16 of 17 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.34 milestone Jun 10, 2025
@github-project-automation github-project-automation bot moved this from Needs Approver to Done in SIG Node: code and documentation PRs Jun 10, 2025
@github-project-automation github-project-automation bot moved this from Archive-it to Done in SIG Node CI/Test Board Jun 10, 2025
@github-project-automation github-project-automation bot moved this from Needs Triage to Done in SIG Apps Jun 10, 2025
This was referenced Jun 12, 2025
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kannon92 kannon92 kannon92 left review comments

@thockin thockin thockin left review comments

@bart0sh bart0sh Awaiting requested review from bart0sh

@justinsb justinsb Awaiting requested review from justinsb

@SergeyKanzhelev SergeyKanzhelev Awaiting requested review from SergeyKanzhelev

Assignees

@SergeyKanzhelev SergeyKanzhelev

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/code-generation area/conformance Issues or PRs related to kubernetes conformance tests area/kubelet area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
SIG Apps
Status: Done
SIG Node CI/Test Board
Status: Done
SIG Node: code and documentation PRs
Archived in project
Milestone
v1.34
Development

Successfully merging this pull request may close these issues.
7 participants
@HirazawaUi @k8s-ci-robot @kannon92 @thockin @SergeyKanzhelev @k8s-triage-robot @bart0sh