Skip to content

schedule pod availability checks at the correct time in ReplicaSets #132121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

schedule pod availability checks at the correct time in ReplicaSets #132121

wants to merge 2 commits into from
+329 −15

Conversation

atiratree
Copy link
Member

What type of PR is this?

/kind bug
/sig apps

What this PR does / why we need it:

Replica set might skip availability checks in certain situations and not update availableReplicas. This also stops deployment from progressing.

This applies to pods that are struggling to become Ready or become Ready with a certain delay.

For more details, please see: #108266 (comment)

Which issue(s) this PR fixes:

Fixes #108266

Special notes for your reviewer:

Similar fix is planned for the other controllers as well.

Does this PR introduce a user-facing change?

ReplicaSets and Deployments should always count `.status.availableReplicas` at the correct time without a delay.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/bug Categorizes issue or PR as related to a bug. sig/apps Categorizes an issue or PR as relevant to SIG Apps. labels Jun 5, 2025
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 5, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in SIG Apps Jun 5, 2025
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 5, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: atiratree
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from kow3ns and mortent June 5, 2025 13:00
This was referenced Jun 5, 2025
Open
Open
@atiratree atiratree force-pushed the rs-minReadySeconds branch from 04f11c1 to 61438d5 Compare June 5, 2025 14:32
@atiratree
Copy link
Member Author

flake
/test pull-kubernetes-node-e2e-containerd

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 11, 2025
@atiratree atiratree force-pushed the rs-minReadySeconds branch from 61438d5 to 6047c80 Compare June 14, 2025 16:41
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kow3ns kow3ns Awaiting requested review from kow3ns

@mortent mortent Awaiting requested review from mortent

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/apps Categorizes an issue or PR as relevant to SIG Apps. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
SIG Apps
Status: Needs Triage
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Kubernetes controller manager may fail to manage deployment rollout with minReadySeconds and pod restarts
2 participants
@atiratree @k8s-ci-robot