Skip to content

metadata client: remove support for API streaming #132149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 9, 2025
Merged

metadata client: remove support for API streaming #132149

merged 2 commits into from
Jun 9, 2025

Conversation

p0lyn0mial
Copy link
Contributor

@p0lyn0mial p0lyn0mial commented Jun 6, 2025 •
edited
Loading

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer: xref: #127388

Does this PR introduce a user-facing change?

Removes support for API streaming from the `List() method` of the metadata client.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 6, 2025
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@p0lyn0mial
Copy link
Contributor Author

/assign @wojtek-t

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Jun 6, 2025
@k8s-ci-robot k8s-ci-robot added area/test sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 6, 2025
@k8s-ci-robot k8s-ci-robot requested review from soltysh and thockin June 6, 2025 14:47
p0lyn0mial
p0lyn0mial commented Jun 6, 2025
View reviewed changes
test/e2e/apimachinery/watchlist.go
@@ -139,7 +139,7 @@ var _ = SIGDescribe("API Streaming (aka. WatchList)", framework.WithFeatureGate(
expectedRequestsMadeByDynamicClient := getExpectedRequestsMadeByClientFor(secretList.GetResourceVersion())
gomega.Expect(rt.actualRequests).To(gomega.Equal(expectedRequestsMadeByDynamicClient))
})
ginkgo.It("should be requested by metadata client's List method when WatchListClient is enabled", func(ctx context.Context) {
ginkgo.It("should NOT be requested by metadata client's List method when WatchListClient is enabled", func(ctx context.Context) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

at some point we should remove this test but i would keep it for a release.

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 9, 2025
@wojtek-t
Copy link
Member

wojtek-t commented Jun 9, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 9, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 07b726e7468ddffa83663aae080d9b19d546d926

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: p0lyn0mial, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 9, 2025
@p0lyn0mial
Copy link
Contributor Author

p0lyn0mial commented Jun 9, 2025 •
edited
Loading

/test pull-kubernetes-e2e-gce-cos-alpha-features

/hold

I just want to make sure that pull-kubernetes-e2e-gce-cos-alpha-features passes

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 9, 2025
@p0lyn0mial
Copy link
Contributor Author

/test pull-kubernetes-e2e-gce-cos-alpha-features

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jun 9, 2025
@k8s-ci-robot k8s-ci-robot removed the release-note-none Denotes a PR that doesn't merit a release note. label Jun 9, 2025
@p0lyn0mial
Copy link
Contributor Author

unit failed on (not related):

=== RUN   TestStreamTranslator_BlockRedirects
E0609 07:09:10.482709   74946 conn.go:339] Error on socket receive: read tcp 127.0.0.1:38087->127.0.0.1:56720: use of closed network connection
E0609 07:09:10.482902   74946 websocket.go:297] Unknown stream id 1, discarding message
E0609 07:09:10.482925   74946 websocket.go:297] Unknown stream id 3, discarding message
    streamtranslator_test.go:828: expected redirect not allowed error, got (closed all streams)
E0609 07:09:10.487736   74946 websocket.go:297] Unknown stream id 1, discarding message
E0609 07:09:10.487934   74946 conn.go:339] Error on socket receive: read tcp 127.0.0.1:44659->127.0.0.1:38506: use of closed network connection
E0609 07:09:10.496119   74946 websocket.go:297] Unknown stream id 1, discarding message
E0609 07:09:10.496342   74946 conn.go:339] Error on socket receive: read tcp 127.0.0.1:32917->127.0.0.1:46688: use of closed network connection
E0609 07:09:10.502420   74946 websocket.go:297] Unknown stream id 1, discarding message
E0609 07:09:10.502634   74946 conn.go:339] Error on socket receive: read tcp 127.0.0.1:34971->127.0.0.1:51148: use of closed network connection
E0609 07:09:10.511859   74946 conn.go:339] Error on socket receive: read tcp 127.0.0.1:42799->127.0.0.1:46100: use of closed network connection
E0609 07:09:10.511989   74946 websocket.go:297] Unknown stream id 1, discarding message
--- FAIL: TestStreamTranslator_BlockRedirects (0.04s)

/test pull-kubernetes-unit

@p0lyn0mial
Copy link
Contributor Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 9, 2025
@k8s-ci-robot k8s-ci-robot merged commit 3aa4486 into kubernetes:master Jun 9, 2025
16 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.34 milestone Jun 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh Awaiting requested review from soltysh

@thockin thockin Awaiting requested review from thockin

Assignees

@wojtek-t wojtek-t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.34
Development

Successfully merging this pull request may close these issues.
3 participants
@p0lyn0mial @k8s-ci-robot @wojtek-t