Skip to content

[FG:InPlacePodVerticalScaling] Add a more complex e2e test for deferred resizes #132152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[FG:InPlacePodVerticalScaling] Add a more complex e2e test for deferred resizes #132152

wants to merge 1 commit into from
+234 −5

Conversation

natasha41575
Copy link
Contributor

@natasha41575 natasha41575 commented Jun 6, 2025 •
edited
Loading

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Creates a more complex e2e test for deferred resizes, where there are several pending resizes that each make room for the next one. Admittedly a slightly contrived scenario, but I still think it's important that this works correctly, especially in contexts where there may be a controller making frequent resize requests.

Motivation: The logic for evaluating pending resizes is becoming more complicated and error prone with #131612. The test ensures that even when there are multiple pending resizes that depend on each other, (a) re-evaluation of the pending resize queue is triggered appropriately and (b) there are no deadlocks, which I was slightly nervous about with the mutex updates.

Special notes for your reviewer:

I was kind of on the fence about whether I should just add this to #131612 or make a separate PR, but since #131612 has already gone through some reviews I figured I wouldn't extend its scope. Also I checked that the test passes with both HEAD today and #131612 which demonstrates that #131612 doesn't change the behavior.

Does this PR introduce a user-facing change?

NONE

/sig node
/priority important-soon
/assign @tallclair

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. sig/node Categorizes an issue or PR as relevant to SIG Node. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Jun 6, 2025
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 6, 2025
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jun 6, 2025
@natasha41575 natasha41575 force-pushed the complex-deferred-test branch from 61c5761 to 6a356fd Compare June 6, 2025 18:32
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: natasha41575
Once this PR has been reviewed and has the lgtm label, please ask for approval from tallclair. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rphillips rphillips Awaiting requested review from rphillips

@wzshiming wzshiming Awaiting requested review from wzshiming

Assignees

@tallclair tallclair

Labels
area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
SIG Node CI/Test Board
Status: Triage
SIG Node: In Place Pod Vertical Scaling
Status: No status
SIG Node: code and documentation PRs
Status: Triage
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@natasha41575 @k8s-ci-robot @tallclair