Build k8s using latest commit of golang #132197

dims · 2025-06-09T19:50:41Z

Run "gimme master" and use the newly built binaries. Adjust GOROOT_BOOTSTRAP so we can use the golang that is already on disk to build the new commit from golang.

To enable this, edit .go-version and set the version to

devel

and then run make quick-release (for example)

/kind cleanup

Context: please see kubernetes/test-infra#34918, We currently build a full kube-cross image when it is not really needed at all. It's flaky and we get throttled and it's a mess!. Since we already allow building against different versions of golang, we should just ensure we support this use case as well.

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR is related to:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

k8s-ci-robot · 2025-06-09T19:50:51Z

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

dims · 2025-06-09T19:50:54Z

/assign @liggitt @BenTheElder

BenTheElder · 2025-06-09T20:23:10Z

hack/lib/golang.sh

@@ -524,6 +524,15 @@ kube::golang::internal::verify_go_version() {
  if [ "${GOTOOLCHAIN:-auto}" != 'auto' ]; then
    # no-op, just respect GOTOOLCHAIN
    :
+  elif [ "${GO_VERSION:-}" == 'devel' ]; then


I was sort of hoping we could move towards the GOTOOLCHAIN standard, we have a lot of ways to configure this currently, and it would be nice to rely on go tooling instead of shell/gimmee when possible.

Does https://pkg.go.dev/golang.org/dl/gotip make sense?

possibly, i was trying to stay within the current boundaries and not introduce more things.

we can open an issue and ask for help if needed.

Done! #132204

This still means we've just expanded the surface area of GO_VERSION.

Is devel a typical name for this in go?

i saw "devel" in go repo - https://github.com/search?q=repo%3Agolang%2Fgo%20%2F%22devel%22%2F&type=code

and i did not want to use "master"

ACK. I just worry a little bit about the behemoth of an "API" we have around this, it's kind of like cluster/, very hard to improve because the user API is poorly defined. GOTOOLCHAIN got us close to removing this bit.

BenTheElder · 2025-06-09T20:24:25Z

third_party/gimme/gimme

@@ -314,8 +314,10 @@ _setup_bootstrap() {
 # _compile "dir"
 _compile() {
 	(
-		if grep -q GOROOT_BOOTSTRAP "${1}/src/make.bash" &>/dev/null; then
-			_setup_bootstrap || return 1
+	  if [[ -z "${GOROOT_BOOTSTRAP}" ]]; then


is there an upstream commit we should sync to instead?

I did not see any changes in this area in upstream @BenTheElder. They had only updated the list of versions above.

previously this code wasn't actually modified IIRC, only copied locally so we don't have to curl | bash

we should probably document any changes we make and consider upstreaming them

pretty static repo, but will try - https://github.com/travis-ci/gimme/commits/master

k8s-ci-robot · 2025-06-09T20:59:26Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~hack/OWNERS~~ [dims]
~~third_party/OWNERS~~ [dims]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

dims · 2025-06-09T21:02:47Z

/sig testing

Run "gimme master" and use the newly built binaries. Adjust GOROOT_BOOTSTRAP so we can use the golang that is already on disk to build the new commit from golang. To enable this, edit `.go-version` and set the version to ``` devel ``` and then run `make quick-release` (for example) Signed-off-by: Davanum Srinivas <[email protected]>

dims · 2025-06-10T12:02:27Z

@BenTheElder opened #132204 for follow up.

/assign @ameukam @upodroid

Are you ok landing this please? need to get back to kubernetes/test-infra#34918 once this lands

ameukam · 2025-06-10T12:09:58Z

/lgtm

k8s-ci-robot · 2025-06-10T12:10:05Z

LGTM label has been added.

Git tree hash: 1aaa61079cb2386bd67ffcdc172bd129c1c3f97e

k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Jun 9, 2025

k8s-ci-robot assigned BenTheElder and liggitt Jun 9, 2025

k8s-ci-robot requested review from logicalhan and smarterclayton June 9, 2025 19:51

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 9, 2025

BenTheElder reviewed Jun 9, 2025

View reviewed changes

dims force-pushed the support-building-k8s-using-go-tip-master branch from 0126604 to 71817d6 Compare June 9, 2025 20:59

k8s-ci-robot added sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 9, 2025

dims changed the title ~~Build k8s using latest commit of golang~~ [WIP] Build k8s using latest commit of golang Jun 9, 2025

k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 9, 2025

dims force-pushed the support-building-k8s-using-go-tip-master branch from 71817d6 to c85ac59 Compare June 9, 2025 21:41

dims changed the title ~~[WIP] Build k8s using latest commit of golang~~ Build k8s using latest commit of golang Jun 9, 2025

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 9, 2025

dims mentioned this pull request Jun 10, 2025

Replacement for gimme #132204

Open

k8s-ci-robot assigned ameukam and upodroid Jun 10, 2025

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 10, 2025

dims mentioned this pull request Jun 10, 2025

Avoid building kube-cross (inject .go-version instead) kubernetes/perf-tests#3387

Merged

k8s-ci-robot merged commit 1a200ab into kubernetes:master Jun 10, 2025
15 checks passed

k8s-ci-robot added this to the v1.34 milestone Jun 10, 2025

Build k8s using latest commit of golang #132197

Build k8s using latest commit of golang #132197

Uh oh!

Conversation

dims commented Jun 9, 2025

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR is related to:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Uh oh!

k8s-ci-robot commented Jun 9, 2025

Uh oh!

dims commented Jun 9, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

k8s-ci-robot commented Jun 9, 2025

Uh oh!

dims commented Jun 9, 2025

Uh oh!

dims commented Jun 10, 2025

Uh oh!

ameukam commented Jun 10, 2025

Uh oh!

k8s-ci-robot commented Jun 10, 2025

Uh oh!

Uh oh!

Uh oh!