Skip to content

e2e: node: serial: fix cgroup path with crio #132215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 11, 2025
Merged

e2e: node: serial: fix cgroup path with crio #132215

merged 1 commit into from
Jun 11, 2025
+1 −1

Conversation

ffromani
Copy link
Contributor

@ffromani ffromani commented Jun 10, 2025 •
edited
Loading

What type of PR is this?

/kind bug
/kind failing-test
/kind flake

What this PR does / why we need it:

Fix cgroup cpu path construction in cri-o

Which issue(s) this PR is related to:

Fixes: #131769

Special notes for your reviewer:

Do we have the same set of pre-submit and periodic jobs? need to check.

Does this PR introduce a user-facing change?

NONE

@ffromani
e2e: node: serial: fix cgroup path with crio
b39741b 
the path construction with crio is wrong (typo).

Signed-off-by: Francesco Romani <[email protected]>
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. kind/flake Categorizes issue or PR as related to a flaky test. kind/regression Categorizes issue or PR as related to a regression from a prior release. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 10, 2025
@ffromani
Copy link
Contributor Author

/test

@k8s-ci-robot k8s-ci-robot added do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 10, 2025
@k8s-ci-robot
Copy link
Contributor

@ffromani: The /test command needs one or more targets.
The following commands are available to trigger required jobs:

/test pull-cos-containerd-e2e-ubuntu-gce

/test pull-kubernetes-cmd

/test pull-kubernetes-cmd-canary

/test pull-kubernetes-cmd-go-canary

/test pull-kubernetes-conformance-kind-ga-only-parallel

/test pull-kubernetes-coverage-unit

/test pull-kubernetes-dependencies

/test pull-kubernetes-dependencies-go-canary

/test pull-kubernetes-e2e-gce

/test pull-kubernetes-e2e-gce-100-performance

/test pull-kubernetes-e2e-gce-cos

/test pull-kubernetes-e2e-gce-cos-canary

/test pull-kubernetes-e2e-gce-cos-no-stage

/test pull-kubernetes-e2e-gce-network-proxy-http-connect

/test pull-kubernetes-e2e-gce-pull-through-cache

/test pull-kubernetes-e2e-gce-scale-performance-manual

/test pull-kubernetes-e2e-kind

/test pull-kubernetes-e2e-kind-ipv6

/test pull-kubernetes-e2e-storage-kind-alpha-beta-features-slow

/test pull-kubernetes-integration

/test pull-kubernetes-integration-canary

/test pull-kubernetes-integration-go-canary

/test pull-kubernetes-kubemark-e2e-gce-scale

/test pull-kubernetes-node-e2e-containerd

/test pull-kubernetes-typecheck

/test pull-kubernetes-unit

/test pull-kubernetes-unit-go-canary

/test pull-kubernetes-update

/test pull-kubernetes-verify

/test pull-kubernetes-verify-go-canary

The following commands are available to trigger optional jobs:

/test check-dependency-stats

/test pull-crio-cgroupv1-node-e2e-eviction

/test pull-crio-cgroupv1-node-e2e-features

/test pull-crio-cgroupv1-node-e2e-hugepages

/test pull-crio-cgroupv1-node-e2e-resource-managers

/test pull-crio-cgroupv2-imagefs-separatedisktest

/test pull-crio-cgroupv2-node-e2e-eviction

/test pull-crio-cgroupv2-node-e2e-hugepages

/test pull-crio-cgroupv2-node-e2e-resource-managers

/test pull-crio-cgroupv2-splitfs-separate-disk

/test pull-e2e-gce-cloud-provider-disabled

/test pull-e2e-gci-gce-alpha-enabled-default

/test pull-kubernetes-apidiff

/test pull-kubernetes-apidiff-client-go

/test pull-kubernetes-conformance-image-test

/test pull-kubernetes-conformance-kind-ga-only

/test pull-kubernetes-conformance-kind-ipv6-parallel

/test pull-kubernetes-cos-cgroupv1-containerd-node-e2e

/test pull-kubernetes-cos-cgroupv1-containerd-node-e2e-features

/test pull-kubernetes-cos-cgroupv2-containerd-node-e2e

/test pull-kubernetes-cos-cgroupv2-containerd-node-e2e-eviction

/test pull-kubernetes-cos-cgroupv2-containerd-node-e2e-features

/test pull-kubernetes-cos-cgroupv2-containerd-node-e2e-serial

/test pull-kubernetes-crio-node-memoryqos-cgrpv2

/test pull-kubernetes-cross

/test pull-kubernetes-e2e-autoscaling-hpa-cm

/test pull-kubernetes-e2e-autoscaling-hpa-cpu

/test pull-kubernetes-e2e-autoscaling-hpa-cpu-alpha-beta

/test pull-kubernetes-e2e-capz-azure-disk

/test pull-kubernetes-e2e-capz-azure-disk-vmss

/test pull-kubernetes-e2e-capz-azure-disk-windows

/test pull-kubernetes-e2e-capz-azure-file

/test pull-kubernetes-e2e-capz-azure-file-vmss

/test pull-kubernetes-e2e-capz-azure-file-windows

/test pull-kubernetes-e2e-capz-conformance

/test pull-kubernetes-e2e-capz-master-windows-nodelogquery

/test pull-kubernetes-e2e-capz-windows-alpha-feature-vpa

/test pull-kubernetes-e2e-capz-windows-alpha-features

/test pull-kubernetes-e2e-capz-windows-master

/test pull-kubernetes-e2e-capz-windows-serial-slow

/test pull-kubernetes-e2e-capz-windows-serial-slow-hpa

/test pull-kubernetes-e2e-containerd-gce

/test pull-kubernetes-e2e-ec2

/test pull-kubernetes-e2e-ec2-arm64

/test pull-kubernetes-e2e-ec2-conformance

/test pull-kubernetes-e2e-ec2-conformance-arm64

/test pull-kubernetes-e2e-ec2-device-plugin-gpu

/test pull-kubernetes-e2e-gce-canary

/test pull-kubernetes-e2e-gce-correctness

/test pull-kubernetes-e2e-gce-cos-alpha-features

/test pull-kubernetes-e2e-gce-csi-serial

/test pull-kubernetes-e2e-gce-device-plugin-gpu

/test pull-kubernetes-e2e-gce-disruptive-canary

/test pull-kubernetes-e2e-gce-kubelet-credential-provider

/test pull-kubernetes-e2e-gce-network-policies

/test pull-kubernetes-e2e-gce-network-proxy-grpc

/test pull-kubernetes-e2e-gce-serial

/test pull-kubernetes-e2e-gce-serial-canary

/test pull-kubernetes-e2e-gce-storage-disruptive

/test pull-kubernetes-e2e-gce-storage-selinux

/test pull-kubernetes-e2e-gce-storage-slow

/test pull-kubernetes-e2e-gce-storage-snapshot

/test pull-kubernetes-e2e-gci-gce-autoscaling

/test pull-kubernetes-e2e-gci-gce-ingress

/test pull-kubernetes-e2e-gci-gce-ipvs

/test pull-kubernetes-e2e-gci-gce-kube-dns-nodecache

/test pull-kubernetes-e2e-gci-gce-nftables

/test pull-kubernetes-e2e-kind-alpha-beta-features

/test pull-kubernetes-e2e-kind-alpha-features

/test pull-kubernetes-e2e-kind-beta-features

/test pull-kubernetes-e2e-kind-canary

/test pull-kubernetes-e2e-kind-cloud-provider-loadbalancer

/test pull-kubernetes-e2e-kind-dependencies

/test pull-kubernetes-e2e-kind-dual-canary

/test pull-kubernetes-e2e-kind-evented-pleg

/test pull-kubernetes-e2e-kind-ipv6-canary

/test pull-kubernetes-e2e-kind-ipvs

/test pull-kubernetes-e2e-kind-kms

/test pull-kubernetes-e2e-kind-multizone

/test pull-kubernetes-e2e-kind-nftables

/test pull-kubernetes-e2e-relaxed-environment-variable-validation

/test pull-kubernetes-e2e-storage-kind-disruptive

/test pull-kubernetes-e2e-storage-kind-volume-group-snapshots

/test pull-kubernetes-e2e-unit-dependencies

/test pull-kubernetes-integration-race

/test pull-kubernetes-kind-dra

/test pull-kubernetes-kind-dra-all

/test pull-kubernetes-kind-dra-all-canary

/test pull-kubernetes-kind-dra-canary

/test pull-kubernetes-kind-json-logging

/test pull-kubernetes-kind-text-logging

/test pull-kubernetes-kubemark-e2e-gce-big

/test pull-kubernetes-linter-hints

/test pull-kubernetes-local-e2e

/test pull-kubernetes-node-arm64-e2e-containerd-ec2

/test pull-kubernetes-node-arm64-e2e-containerd-serial-ec2

/test pull-kubernetes-node-arm64-ubuntu-serial-gce

/test pull-kubernetes-node-crio-cgrpv1-evented-pleg-e2e

/test pull-kubernetes-node-crio-cgrpv2-e2e

/test pull-kubernetes-node-crio-cgrpv2-e2e-canary

/test pull-kubernetes-node-crio-cgrpv2-imagefs-e2e

/test pull-kubernetes-node-crio-cgrpv2-imagevolume-e2e

/test pull-kubernetes-node-crio-cgrpv2-splitfs-e2e

/test pull-kubernetes-node-crio-cgrpv2-userns-e2e-serial

/test pull-kubernetes-node-crio-e2e

/test pull-kubernetes-node-e2e-alpha-ec2

/test pull-kubernetes-node-e2e-containerd-1-7-dra

/test pull-kubernetes-node-e2e-containerd-1-7-dra-canary

/test pull-kubernetes-node-e2e-containerd-2-0-dra

/test pull-kubernetes-node-e2e-containerd-2-0-dra-canary

/test pull-kubernetes-node-e2e-containerd-alpha-features

/test pull-kubernetes-node-e2e-containerd-ec2

/test pull-kubernetes-node-e2e-containerd-features

/test pull-kubernetes-node-e2e-containerd-features-kubetest2

/test pull-kubernetes-node-e2e-containerd-kubelet-psi

/test pull-kubernetes-node-e2e-containerd-kubetest2

/test pull-kubernetes-node-e2e-containerd-serial-ec2

/test pull-kubernetes-node-e2e-containerd-serial-ec2-eks

/test pull-kubernetes-node-e2e-containerd-standalone-mode

/test pull-kubernetes-node-e2e-containerd-standalone-mode-all-alpha

/test pull-kubernetes-node-e2e-cri-proxy-serial

/test pull-kubernetes-node-e2e-crio-cgrpv1-dra

/test pull-kubernetes-node-e2e-crio-cgrpv1-dra-canary

/test pull-kubernetes-node-e2e-crio-cgrpv2-dra

/test pull-kubernetes-node-e2e-crio-cgrpv2-dra-canary

/test pull-kubernetes-node-e2e-resource-health-status

/test pull-kubernetes-node-kubelet-containerd-flaky

/test pull-kubernetes-node-kubelet-credential-provider

/test pull-kubernetes-node-kubelet-serial-containerd

/test pull-kubernetes-node-kubelet-serial-containerd-alpha-features

/test pull-kubernetes-node-kubelet-serial-containerd-kubetest2

/test pull-kubernetes-node-kubelet-serial-containerd-sidecar-containers

/test pull-kubernetes-node-kubelet-serial-cpu-manager

/test pull-kubernetes-node-kubelet-serial-cpu-manager-kubetest2

/test pull-kubernetes-node-kubelet-serial-crio-cgroupv1

/test pull-kubernetes-node-kubelet-serial-crio-cgroupv2

/test pull-kubernetes-node-kubelet-serial-hugepages

/test pull-kubernetes-node-kubelet-serial-memory-manager

/test pull-kubernetes-node-kubelet-serial-podresources

/test pull-kubernetes-node-kubelet-serial-topology-manager

/test pull-kubernetes-node-kubelet-serial-topology-manager-kubetest2

/test pull-kubernetes-node-swap-conformance-fedora-serial

/test pull-kubernetes-node-swap-conformance-ubuntu-serial

/test pull-kubernetes-node-swap-fedora

/test pull-kubernetes-node-swap-fedora-serial

/test pull-kubernetes-node-swap-ubuntu-serial

/test pull-kubernetes-scheduler-perf

/test pull-kubernetes-unit-windows-master

/test pull-publishing-bot-validate

Use /test all to run the following jobs that were automatically triggered:

pull-kubernetes-cmd

pull-kubernetes-conformance-kind-ga-only-parallel

pull-kubernetes-dependencies

pull-kubernetes-e2e-ec2

pull-kubernetes-e2e-gce

pull-kubernetes-e2e-kind

pull-kubernetes-e2e-kind-ipv6

pull-kubernetes-integration

pull-kubernetes-linter-hints

pull-kubernetes-node-e2e-containerd

pull-kubernetes-typecheck

pull-kubernetes-unit

pull-kubernetes-verify

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ffromani

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 10, 2025
@ffromani
Copy link
Contributor Author

/test pull-crio-cgroupv2-node-e2e-resource-managers
/test pull-crio-cgroupv2-node-e2e-hugepages
/test pull-kubernetes-crio-node-memoryqos-cgrpv2
/test pull-kubernetes-node-crio-cgrpv2-e2e
/test pull-kubernetes-node-crio-cgrpv2-e2e-canary
/test pull-kubernetes-node-crio-e2e
/test pull-kubernetes-node-e2e-crio-cgrpv2-dra
/test pull-kubernetes-node-e2e-crio-cgrpv2-dra-canary
/test pull-kubernetes-node-kubelet-serial-crio-cgroupv2
/test pull-crio-cgroupv2-node-e2e-resource-managers
/test pull-crio-cgroupv1-node-e2e-resource-managers

@ffromani
Copy link
Contributor Author

/cc @kannon92

@k8s-ci-robot k8s-ci-robot requested a review from kannon92 June 10, 2025 17:33
@ffromani ffromani mentioned this pull request Jun 10, 2025
Open
@kannon92
Copy link
Contributor

/triage accepted
/priority important-soon

/hold

/lgtm

Please unhold if CI passes.

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 10, 2025
@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 10, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e0bf9064b2a4efe27a7bfec52a945b2b4bdc9d64

@ffromani
Copy link
Contributor Author

/test pull-kubernetes-node-swap-ubuntu-serial
/test pull-kubernetes-node-arm64-e2e-containerd-ec2
/test pull-kubernetes-node-arm64-e2e-containerd-serial-ec2
/test pull-kubernetes-node-arm64-ubuntu-serial-gce
/test pull-kubernetes-node-e2e-containerd-ec2
/test pull-kubernetes-node-e2e-containerd-serial-ec2

@ffromani
Copy link
Contributor Author

/test pull-kubernetes-node-kubelet-serial-containerd
/test pull-kubernetes-node-kubelet-serial-containerd-sidecar-containers
/test pull-kubernetes-node-kubelet-serial-cpu-manager
/test pull-kubernetes-node-kubelet-serial-hugepages
/test pull-kubernetes-node-kubelet-serial-memory-manager
/test pull-kubernetes-node-kubelet-serial-topology-manager

@ffromani
Copy link
Contributor Author

/test pull-crio-cgroupv2-node-e2e-resource-managers
/test pull-crio-cgroupv1-node-e2e-resource-managers

@ffromani
Copy link
Contributor Author

ffromani commented Jun 11, 2025 •
edited
Loading

pull-kubernetes-node-kubelet-serial-crio-cgroupv2 skips by design cpu manager tests, no point in retrying
pull-kubernetes-node-e2e-containerd-serial-ec2 failed for a different reason, the cpumanager test run correctly
pull-kubernetes-node-crio-cgrpv2-e2e skips by design cpu manager tests, no point in retrying
pull-kubernetes-crio-node-memoryqos-cgrpv2 skips by design cpu manager tests, no point in retrying

@k8s-ci-robot
Copy link
Contributor

@ffromani: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-crio-node-memoryqos-cgrpv2 b39741b link false /test pull-kubernetes-crio-node-memoryqos-cgrpv2
pull-kubernetes-node-crio-cgrpv2-e2e b39741b link false /test pull-kubernetes-node-crio-cgrpv2-e2e
pull-kubernetes-node-e2e-containerd-serial-ec2 b39741b link false /test pull-kubernetes-node-e2e-containerd-serial-ec2
pull-kubernetes-node-kubelet-serial-crio-cgroupv2 b39741b link false /test pull-kubernetes-node-kubelet-serial-crio-cgroupv2
pull-crio-cgroupv1-node-e2e-resource-managers b39741b link false /test pull-crio-cgroupv1-node-e2e-resource-managers
pull-crio-cgroupv2-node-e2e-resource-managers b39741b link false /test pull-crio-cgroupv2-node-e2e-resource-managers

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ffromani
Copy link
Contributor Author

it seems the pod density test breaks the machine running the lane

@ffromani
Copy link
Contributor Author

/unhold

From what I gathered this fix should help, and can't break the lanes more than they are already, as it is targeted towards crio only.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 11, 2025
@ffromani
Copy link
Contributor Author

/remove-kind regression

it's a gap, but it seems the rewritten tests never worked on crio :\ (which is arguably worse)

@k8s-ci-robot k8s-ci-robot removed the kind/regression Categorizes issue or PR as related to a regression from a prior release. label Jun 11, 2025
@k8s-ci-robot k8s-ci-robot merged commit 8afdc55 into kubernetes:master Jun 11, 2025
30 of 36 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.34 milestone Jun 11, 2025
@github-project-automation github-project-automation bot moved this from Triage to Done in SIG Node CI/Test Board Jun 11, 2025
@ffromani ffromani deleted the e2e-serial-cpumgr-crio-fix branch June 11, 2025 11:38
@ffromani
Copy link
Contributor Author

it seems the fix worked:
https://testgrid.k8s.io/sig-node-kubelet#kubelet-gce-e2e-swap-fedora-serial
https://testgrid.k8s.io/sig-node-cri-o#ci-crio-cgroupv2-node-e2e-resource-managers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewsykim andrewsykim Awaiting requested review from andrewsykim

@odinuge odinuge Awaiting requested review from odinuge

@kannon92 kannon92 Awaiting requested review from kannon92

Assignees

@kannon92 kannon92

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. kind/flake Categorizes issue or PR as related to a flaky test. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node CI/Test Board
Status: Done
SIG Node: code and documentation PRs
Archived in project
Milestone
v1.34
3 participants
@ffromani @k8s-ci-robot @kannon92