feat(validation-gen): add default validation ratcheting support #132236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
k8s-ci-robot
removed
the
do-not-merge/needs-sig
|
/triage accepted |
k8s-ci-robot
added
triage/accepted
|
This PR may require API review. If so, when the changes are ready, complete the pre-review checklist and request an API review. Status of requested reviews is tracked in the API Review project. |
yongruilin
force-pushed
the
master_vg_ratcheting-default
branch
from
bb10a8e to
1619372
Compare
k8s-ci-robot
added
area/kubelet
sig/auth
github-project-automation
bot
moved this to Triage
in SIG Node: code and documentation PRs
…nctions This commit introduces a new utility package for the validation generator, encapsulating functions for type handling, including `GetMemberByJSON`, `IsNilableType`, `NativeType`, and `NonPointer`. The existing code has been refactored to utilize these new utility functions, improving code clarity and maintainability. Additionally, the previous unaliasing logic has been removed in favor of the new utility methods, streamlining type validation processes across the codebase. Co-authored-by: Tim Hockin <[email protected]>
Emit equivalence check before emit validators when needed.
yongruilin
force-pushed
the
master_vg_ratcheting-default
branch
from
1619372 to
ac467d3
Compare
|
Thanks! /lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 6030a46f021544138e37588445c3d05ec02f596a
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: thockin, yongruilin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
github-project-automation
bot
moved this from Triage
to Done
in SIG Node: code and documentation PRs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR is part of Declarative Validation # ratcheting. It adds the default validation ratcheting support in the generated code.
It includes:
Which issue(s) this PR is related to:
Ref: kubernetes/enhancements#5073
Special notes for your reviewer:
The KEP update has merged: kubernetes/enhancements#5292
The change has been reviewed and merged in the dev repo jpbetz/validation-gen#55
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: