Skip to content

Add FXIOS-12396 Default Zoom Feature tests #27298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add FXIOS-12396 Default Zoom Feature tests #27298

wants to merge 1 commit into from
+38 −0

Conversation

DEADLK
Copy link
Contributor

@DEADLK DEADLK commented Jun 12, 2025

📜 Tickets

Jira ticket
Github issue

💡 Description

Tests for the default zoom feature added to ZoomPageManagerTests

🎥 Demos

Before After
Demo

📝 Checklist

  • [ x] I filled in the ticket numbers and a description of my work
  • [x ] I updated the PR name to follow our PR naming guidelines
  • [x ] I ensured unit tests pass and wrote tests for new code
  • [ x] If working on UI, I checked and implemented accessibility (Dynamic Text and VoiceOver)
  • [ x] If adding telemetry, I read the data stewardship requirements and will request a data review
  • [x ] If needed, I updated documentation and added comments to complex code
  • [ x] If needed, I added a backport comment (example @Mergifyio backport release/v120)

@DEADLK DEADLK requested a review from a team as a code owner June 12, 2025 18:52
@DEADLK DEADLK requested a review from mattreaganmozilla June 12, 2025 18:52
@mattreaganmozilla
Copy link
Collaborator

Thanks @DEADLK for this PR. Just double-checking, but it looks like the ticket does not have a contributor label. It also doesn't have a description, so I'm not 100% clear if this is addressing the expected requirements.

cc @yoanarios Looks like you filed the original Jira, can you possibly confirm? Thank you

@DEADLK
Copy link
Contributor Author

DEADLK commented Jun 13, 2025

Sorry 😅 it absolutely makes sense that the task should be marked with a contribution tag. I just wanted to start with something simple — hopefully a couple of unit tests won’t hurt anyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattreaganmozilla mattreaganmozilla Awaiting requested review from mattreaganmozilla mattreaganmozilla is a code owner automatically assigned from mozilla-mobile/fxios-eng

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DEADLK @mattreaganmozilla