fix(core): Ensure queue is ready when enqueueing #16098
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
cubic found 1 issue across 3 files. Review it in cubic.dev
React with 👍 or 👎 to teach cubic. Tag @cubic-dev-ai to give specific feedback.
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
afitzek
reviewed
Jun 6, 2025
n8n-assistant
bot
added
core
|
@ivov I frequently encounter this situation. To reproduce it, concurrent task execution is needed, and errors occur frequently under such conditions. |
afitzek
approved these changes
Jun 10, 2025
|
|
|
✅ All Cypress E2E specs passed |
This was referenced Jun 11, 2025
Closed
Closed
Merged
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There are edge cases where
WorkflowRunnerattempts to enqueue before the queue is ready. For legacy reasonsScalingServiceis being dynamically imported in multiple spots, so this is a risk and appears to be related to workers enqueuing executions of error-handling workflows, but I have not been able to reproduce the edge case locally.This PR ensures the queue is ready when enqueuing. The root solution would be to modularize scaling mode and remove its multiple dynamic imports, and so that all code paths relying on scaling mode are guaranteed that scaling mode init is complete. Adi made an attempt at #11278 but was not satisfied.
Let's fix this now for the time being and work towards modularizing scaling mode when time allows.
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/CAT-784
Fix #15233
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)