-
Notifications
You must be signed in to change notification settings - Fork 29.5k
fix(editor): Solve the problem of non-English characters displaying "_" when downloading workflows #16116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…aligned with the icon on the left when a validation error occurred
…ame is incomplete
luka seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cubic reviewed 1 file and found no issues. Review PR in cubic.dev.
name = name.replace(
/[^a-zA-Z0-9\u4e00-\u9fa5\uAC00-\uD7A3\u3040-\u30FF\u0E00-\u0E7F\u0600-\u06FF\u0370-\u03FF\u0400-\u04FF\u0100-\u017F._-]/g,
'_'
).replace(/^\.+/, '_'); 🔹 First
|
Hey @luka-mimi, Thanks for the PR, We have created "GHC-2404" as the internal reference to get this reviewed. One of us will be in touch if there are any changes needed, in most cases this is normally within a couple of weeks but it depends on the current workload of the team. |
Summary
Solve the problem of non-English characters displaying "_" when downloading workflows
Related Linear tickets, Github issues, and Community forum posts
Review / Merge checklist
release/backport
(if the PR is an urgent fix that needs to be backported)