-
Notifications
You must be signed in to change notification settings - Fork 906
Support /bin/sh
#1530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jason-huh
wants to merge
66
commits into
nghttp2:quic
Choose a base branch
from
jason-huh:quic
base: quic
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Support /bin/sh
#1530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Non-zero successful error code is a bit annoying because ngtcp2 does not know it. Enforcing successful application error code to 0 is a lot simpler.
libjemalloc1 package doesn't exist as it's now libjemalloc2 named Get:1 http://security.debian.org/debian-security buster/updates InRelease [65.4 kB] Get:2 http://deb.debian.org/debian buster InRelease [121 kB] Get:3 http://deb.debian.org/debian buster-updates InRelease [51.9 kB] Get:4 http://security.debian.org/debian-security buster/updates/main amd64 Packages [213 kB] Get:5 http://deb.debian.org/debian buster/main amd64 Packages [7905 kB] Get:6 http://deb.debian.org/debian buster-updates/main amd64 Packages [7868 B] Fetched 8364 kB in 1s (6499 kB/s) Reading package lists... Reading package lists... Building dependency tree... Reading state information... E: Unable to locate package libjemalloc1 fix reference to OpenSSL 1.1.1 branch Cloning into 'openssl'... warning: Could not find remote branch OpenSSL_1_1_1d-quic-draft-29 to clone. fatal: Remote branch OpenSSL_1_1_1d-quic-draft-29 not found in upstream origin
`&>` is not supported by `/bin/sh/`, (but by `/bin/bash/`).
a3aac34
to
0942cc1
Compare
5743ce6
to
7191f61
Compare
ba3f762
to
217d2fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
&>
is not supported by/bin/sh/
, (but by/bin/bash/
).Building with such a syntax failed with the docker setting.
We need to modify the
Dockerfile
as well, but I choose to leave to the maintainers, as doing so would break the convention.Here is what I used for my project:
(Side note: I learned that it is recommended to divide the commands as much as possible in
Dockerfile
, from the official docs.)where
Makefile.am
contains the patch.