Skip to content

Fix setting MANPATH in csh #2140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 9, 2025
Merged

Fix setting MANPATH in csh #2140

merged 1 commit into from
May 9, 2025

Conversation

opoplawski
Copy link
Contributor

This fixes #2139

Escaping everything needed is tricky, so switched to using 'EOF'. In the current version the backticks in the MANPATH command were not escaped and so evaluated to `` when building the RPM.

I don't think the .tar.gz#$ is really needed, but I can re-add if the change breaks your workflow. It's presence broke mine.

I still think it's not great to unconditionally append : to MANPATH - what if it was already present?

Signed-off-by: Orion Poplawski <[email protected]>
Copy link

github-actions bot commented May 8, 2025

Test Results

 30 files   - 18  30 suites   - 18   37s ⏱️ -11s
 54 tests  - 15  50 ✅  - 12  4 💤  - 3  0 ❌ ±0 
102 runs   - 45  96 ✅  - 36  6 💤  - 9  0 ❌ ±0 

Results for commit 2898922. ± Comparison against base commit 7439bae.

This pull request removes 16 and adds 1 tests. Note that renamed tests count towards both.
magpie ‑ [magpie] Verify MAGPIE module is loaded and matches rpm version
magpie ‑ [magpie] Verify module MAGPIE_DIR is defined and exists
magpie ‑ [magpie] check for RPM
mem_limits ‑ [memlock] check increased hard limit
mem_limits ‑ [memlock] check increased soft limit
munge ‑ [munge] Decode credential locally
munge ‑ [munge] Generate a credential
munge ‑ [munge] Run benchmark
munge ‑ [munge] check for OS provdied RPM
ompi_info ‑ [openmpi] check for no output to stderr with ompi_info
…
lmod ‑ [lmod] test that the setup function passed

@adrianreber
Copy link
Member

I don't think the .tar.gz#$ is really needed, but I can re-add if the change breaks your workflow. It's presence broke mine.

Let's see if it works in OBS. Not sure why it exists.

I still think it's not great to unconditionally append : to MANPATH - what if it was already present?

See #2070 and #2105. Initially it was checking if the colon exists at the end, but that wasn't working correctly for all use cases. Not sure, maybe the check was not working correctly. So I didn't want to completely undo the change because having the colon at the end made sense. If you have a better solution, please provide a patch. Maybe with your changes concerning escaping $ it would now work better.

@adrianreber adrianreber merged commit 71d2740 into openhpc:3.x May 9, 2025
25 checks passed
@adrianreber
Copy link
Member

The build system is happy with your changes: https://obs.openhpc.community/package/show/OpenHPC3:3.3.1:Factory/lmod

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New lmod.csh is broken
2 participants