Skip to content

impi: Adjust version parsing to deal with spaces #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

chuckatkins
Copy link

This makes the version parsing replace " Update " with "." to prevent
spaces in generated module file names, which breaks other module
infrastructure. This is specifically to address a problem with the impi
shipped with Parallel Studio Cluster Edition 2017 Update 1, in which
the version retrieved for automatic module file creation was
"2017 Update 1". This now becomes "2017.1" thus resulting in a more
sensible module file name that doesn't break the remaining module
infrastructure..

This makes the version parsing replace " Update " with "." to prevent
spaces in generated module file names, which breaks other module
infrastructure.  This is specifically to address a problem with the impi
shipped with Parallel Studio Cluster Edition 2017 Update 1, in which
the version retrieved for automatic module file creation  was
"2017 Update 1". This now becomes "2017.1" thus resulting in a more
sensible module file name that doesn't break the remaining module
infrastructure..
@chuckatkins
Copy link
Author

Fixes #343

@chuckatkins chuckatkins reopened this Nov 18, 2016
@chuckatkins
Copy link
Author

Fixes #343

koomie added a commit that referenced this pull request Nov 18, 2016
@chuckatkins
Copy link
Author

If I had known it was to get pulled into the release branch I would have based it much earlier in the graph. It looks like the merged into obs/OpenHPC_1.2.1_Factory pulled in a bunch of unrelated stuff. Would it be helpful if I rebased the branch back to the v1.2.GA tag instead? the commit is trivial so there shouldn't be any conflicts. That will let it cleanly merge into both master and release.

Or, since you already did the merge should I just leave it alone instead?

@koomie
Copy link
Contributor

koomie commented Nov 18, 2016

It's ok. I probably should have cherry-picked it to avoid pulling in unrelated stuff from master branch but it's landed on 1.2.1 now.

@koomie koomie added this to the 1.2.1 milestone Jan 5, 2017
@koomie koomie closed this Jan 5, 2017
@chuckatkins chuckatkins deleted the fix-impi-version-spaces branch June 21, 2017 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants