impi: Adjust version parsing to deal with spaces #342
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the version parsing replace " Update " with "." to prevent spaces in generated module file names, which breaks other module infrastructure. This is specifically to address a problem with the impi shipped with Parallel Studio Cluster Edition 2017 Update 1, in which the version retrieved for automatic module file creation was "2017 Update 1". This now becomes "2017.1" thus resulting in a more sensible module file name that doesn't break the remaining module infrastructure..
|
Fixes #343 |
|
Fixes #343 |
koomie
added a commit
that referenced
this pull request
Nov 18, 2016
|
If I had known it was to get pulled into the release branch I would have based it much earlier in the graph. It looks like the merged into obs/OpenHPC_1.2.1_Factory pulled in a bunch of unrelated stuff. Would it be helpful if I rebased the branch back to the v1.2.GA tag instead? the commit is trivial so there shouldn't be any conflicts. That will let it cleanly merge into both master and release. Or, since you already did the merge should I just leave it alone instead? |
|
It's ok. I probably should have cherry-picked it to avoid pulling in unrelated stuff from master branch but it's landed on 1.2.1 now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the version parsing replace " Update " with "." to prevent
spaces in generated module file names, which breaks other module
infrastructure. This is specifically to address a problem with the impi
shipped with Parallel Studio Cluster Edition 2017 Update 1, in which
the version retrieved for automatic module file creation was
"2017 Update 1". This now becomes "2017.1" thus resulting in a more
sensible module file name that doesn't break the remaining module
infrastructure..