Separation of data preparation and plotting for criterion_plot()
#600
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
🚀 New features to boost your workflow:
|
r3kste
force-pushed
the
separate_data_from_plot
branch
from
7fb293a to
839ca0c
Compare
timmens
requested changes
May 28, 2025
|
I have made the suggested changes and I believe that the failing test is unrelated. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Separated the logic for data preparation and plotting in
criterion_plot(). This is done to easily enable the addition of plotting backends.LineDatastores required data for plotting a single line.CriterionPlotDatastores all backend agnostic data needed forcriterion_plot()[lines and multistart_lines if applicable]PlotConfigstores global settings of plotsAdditionally, we could add a new parameter such as
return_data- which would return theplot_datainstead of plotting. This can be discussed, if it is worth looking into.