Fix: Resolve PG17 incompatibility for ENUMS in CASE statements #6099
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vcovo |
|
This pull request has not seen any recent activity. |
|
@gen740 in case it was missed I added the requested tests. Let me know if anything is still missing for this to be merged. |
c-bata
reviewed
Jun 12, 2025
Comment on lines
+201
to
+212
| ( | ||
| TrialValueModel.value_type == TrialValueModel.TrialValueType.INF_NEG, | ||
| -1, | ||
| ), | ||
| ( | ||
| TrialValueModel.value_type == TrialValueModel.TrialValueType.FINITE, | ||
| 0, | ||
| ), | ||
| ( | ||
| TrialValueModel.value_type == TrialValueModel.TrialValueType.INF_POS, | ||
| 1, | ||
| ), |
There was a problem hiding this comment.
[question] I didn't tested yet, but based on the error message, can we simply write these lines like this?
Suggested change
| ( | |
| TrialValueModel.value_type == TrialValueModel.TrialValueType.INF_NEG, | |
| -1, | |
| ), | |
| ( | |
| TrialValueModel.value_type == TrialValueModel.TrialValueType.FINITE, | |
| 0, | |
| ), | |
| ( | |
| TrialValueModel.value_type == TrialValueModel.TrialValueType.INF_POS, | |
| 1, | |
| ), | |
| {"INF_NEG": -1, "FINITE": 0, "INF_POS": 1}, | |
| value=TrialValueModel.value_type.value, |
|
Let me change the reviewer since I'll be on leave until the week after next. @y0z Could you review this PR? |
c-bata
added
the
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I have a postgresql 17.3 DB that I also wanted to use for the results of the trials ran through Optuna - potentially linking them with my own tables through a common id. Unfortunately this lead to an error:
operator does not exist: trialvaluetype = character varyingerror when using PostgreSQL 17.3 as explained in #6096.Description of the changes
This changes the SQLAlchemy case() structure in TrialModel.find_max/min_value_trial_id to directly compare the ENUM column with Python ENUM members, avoiding problematic VARCHAR casts on string literals.