Skip to content

Clean up GP-related docs #6125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 12, 2025
Merged

Conversation

nabenabe0928
Copy link
Contributor

Motivation

This PR makes the GP-related documentations cleaner.

Description of the changes

  • Bundle the shape information of tensors (and arrays) at the top of the file

@nabenabe0928 nabenabe0928 marked this pull request as ready for review June 4, 2025 07:31
@nabenabe0928 nabenabe0928 added the code-fix Change that does not change the behavior, such as code refactoring. label Jun 5, 2025
@nabenabe0928
Copy link
Contributor Author

@sawa3030 @kAIto47802 Could you check this PR?

Copy link
Collaborator

@kAIto47802 kAIto47802 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR. LGTM!

Copy link

codecov bot commented Jun 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.30%. Comparing base (1fe6f76) to head (5d0b091).
Report is 58 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6125      +/-   ##
==========================================
+ Coverage   88.29%   88.30%   +0.01%     
==========================================
  Files         207      207              
  Lines       14034    14025       -9     
==========================================
- Hits        12391    12385       -6     
+ Misses       1643     1640       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sawa3030
Copy link
Collaborator

Apologies for the delay. I’ve left a minor comment. PTAL

Co-authored-by: Eri Sawada <[email protected]>
@nabenabe0928
Copy link
Contributor Author

@sawa3030
I've applied your suggestion, PTAL!

Copy link
Collaborator

@sawa3030 sawa3030 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@y0z y0z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@y0z y0z merged commit dabfc38 into optuna:master Jun 12, 2025
14 checks passed
@y0z y0z added this to the v4.5.0 milestone Jun 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-fix Change that does not change the behavior, such as code refactoring.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants