Fix #74269 - Strict comparison of initial trait property values #2468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Isn't this a case for typed properties? As it stands right now, properties in PHP are untyped, hence, the assignment is legal. |
|
@Fleshgrinder in this it is not much about the type, but about the initial value. From the docs on traits:
|
|
I see, all fine. 👍 |
|
Can you include an entry to |
|
I have added the entry to |
nikic
approved these changes
May 1, 2017
|
Merged as 92124f9, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link for bugsnet: https://bugs.php.net/bug.php?id=74269
Given the potential BC break, should probably be only for master.