Skip to content

Fix #79588: Boolean opcache settings ignore on/off values #5560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix #79588: Boolean opcache settings ignore on/off values #5560

wants to merge 1 commit into from

Conversation

cmb69
Copy link
Member

@cmb69 cmb69 commented May 12, 2020

We should display boolean INI settings as boolean.

Might be overzealous to target PHP-7.3; master is fine for me as well.

@cmb69
Fix #79588: Boolean opcache settings ignore on/off values
cf118f9 
We should display boolean INI settings as boolean.
@cmb69
Copy link
Member Author

cmb69 commented May 12, 2020

Thanks! Applied as 5bdb4ab.

@cmb69 cmb69 closed this May 12, 2020
@cmb69 cmb69 deleted the cmb/79588 branch May 12, 2020 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikic nikic nikic approved these changes

Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cmb69 @nikic @carusogabriel