Skip to content

Fix #80345: PHPIZE configuration has outdated PHP_RELEASE_VERSION #6419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix #80345: PHPIZE configuration has outdated PHP_RELEASE_VERSION #6419

wants to merge 1 commit into from

Conversation

cmb69
Copy link
Member

@cmb69 cmb69 commented Nov 10, 2020

We must not redefine the version "constants" for phpize builds, because
these have already generated in phpize.js, from where we pass these
variables forward to configure.js.

We also add PHP_EXTRA_VERSION and PHP_VERSION_STRING to the files
for completeness.

@cmb69
Fix #80345: PHPIZE configuration has outdated PHP_RELEASE_VERSION
aba4a57 
We must not redefine the version "constants" for phpize builds, because
these have already generated in phpize.js, from where we pass these
variables forward to configure.js.

We also add `PHP_EXTRA_VERSION` and `PHP_VERSION_STRING` to the files
for completeness.
@cmb69 cmb69 added the Bug label Nov 10, 2020
@cmb69
Copy link
Member Author

cmb69 commented Nov 17, 2020

@weltling, @KalleZ, @Jan-E, any thoughts on this?

@php-pulls php-pulls closed this in c2b1182 Nov 19, 2020
@cmb69 cmb69 deleted the cmb/80345 branch November 19, 2020 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cmb69