Skip to content

Fix #81380 observer may not be initialized properly #7524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix #81380 observer may not be initialized properly #7524

wants to merge 1 commit into from

Conversation

krakjoe
Copy link
Member

@krakjoe krakjoe commented Sep 28, 2021

Observer must take more care to initialize global (and tls) variables as it expects them to be initialized.

krakjoe
krakjoe commented Sep 28, 2021
View reviewed changes
krakjoe
krakjoe commented Sep 28, 2021
View reviewed changes
morrisonlevi
morrisonlevi reviewed Sep 28, 2021
View reviewed changes
dstogov
dstogov approved these changes Sep 29, 2021
View reviewed changes
Copy link
Member

@dstogov dstogov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right.

@krakjoe
Copy link
Member Author

krakjoe commented Sep 29, 2021

Merged as c884a5a

Thanks.

@krakjoe krakjoe closed this Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morrisonlevi morrisonlevi morrisonlevi left review comments

@nikic nikic nikic approved these changes

@dstogov dstogov dstogov approved these changes

@SammyK SammyK Awaiting requested review from SammyK

@bwoebi bwoebi Awaiting requested review from bwoebi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@krakjoe @nikic @morrisonlevi @dstogov