Skip to content

fix(stack): fix lifecycle hook from not getting called, issue #12452 #12512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

chris-gputrader
Copy link

closes #12452

Changes:

Added project to api.StartOptions for api.UpOptions in stack Deploy.

@joshfrias
Copy link

Any movement here. I'm having issues because of this.

@maggie44
Copy link

@chris-gputrader you did the background research on this on the Docker repo issue. I would suggest cross posting it to help explain how this fix works and to validate the approach. It will help encourage the merge.

@chris-gputrader
Copy link
Author

Sure, as I was digging into the issue I initially thought this had to do with the compose library and created an issue here: docker/compose#12513

After debugging and getting help from the compose community I found out that we had to add Project to the Deploy and Remove functions in the portainer compose plugin.

There is an edge case that I haven't figured out though. This works fine when a stack gets Deployed, or Removed. If a container is restarted these don't trigger because container start/stop/restart don't use the compose plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not honoring Compose lifecycle hooks
3 participants