Skip to content

feat(image-details): display image digest #12567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

Guiorgy
Copy link

@Guiorgy Guiorgy commented Feb 28, 2025

closes #3554

Changes:

  • fixed Dockerfile FromAsCasing warnings: 'as' and 'FROM' keywords' casing do not match
  • fixed Fockerfile LegacyKeyValueFormat warnings: "ENV key=value" should be used instead of legacy "ENV key value" format
  • exposed image RepoDigests in the image details view

Screenshots:

  • image with no digest
    image

  • image with digest
    image

Notes

  • if the image has no digest, the row is hidden
  • since an image may have more than one digest, the right column is itself a table. Currently this is true even if there's only one digest. We could change this, so that if there's only one digest in the array, a normal row will be shown with Digest key on the left and the digest value on the right, and only show Digests with a table on the right when there are more than one digests. This would, however, mean almost duplicating the row html code.
  • I made the digests table datatable class, which removes the bottom margine, which is simmilar to the environmental variables table which also has that class. However, the labels table doesn't have this class and thus has a bottom margin of 20px, is this intentional, or was the datatable class missed for that?

PS. Force push was to amend the issue reference in the commit message (changed from discussion reference #9595 to issue reference #3554)

@Guiorgy Guiorgy force-pushed the feat9595-display-image-digest branch from 5cb13d8 to 4373094 Compare February 28, 2025 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose docker image digests in the UI
1 participant