Improve editorConfigToPrettier
#17512
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
✅ Deploy Preview for prettier ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
fisker
commented
May 24, 2025
Comment on lines
-66
to
-68
| ).toStrictEqual({ | ||
| tabWidth: 0, | ||
| }); |
There was a problem hiding this comment.
The value 0 is invalid, discussed in josephfrazier/editorconfig-to-prettier#1 and decided to keep it, but tabWidth=0 crashes, I think better to ignore instead.
fisker
commented
May 24, 2025
| if (result.useTabs === false && isPositiveInteger(indent_size)) { | ||
| result.tabWidth = indent_size; | ||
| } else if (isPositiveInteger(tab_width)) { | ||
| result.tabWidth = tab_width; |
There was a problem hiding this comment.
According to https://github.com/editorconfig/editorconfig/wiki/EditorConfig-Properties tab_width should only used when indent_size === "tab" and fallback to indent_size, should we follow?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
docs/directory).changelog_unreleased/*/XXXX.mdfile followingchangelog_unreleased/TEMPLATE.md.