-
Notifications
You must be signed in to change notification settings - Fork 156
[WIP] Add numerics functions #253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: numerics-backend
Are you sure you want to change the base?
[WIP] Add numerics functions #253
Conversation
…axis, ones and pi
…uniformize prototypes of other functions
@nkoep I implemented the numpy backend for all the functions you added to the TODO list. |
…kend tests should be run
…assert_array_almost_equal
…t_numerics_supported_backends
@nkoep, I changed quite a lot of things, but we are getting close to having the first version of the multi-backend support for manifolds operations! For now, I focused on having this working for numpy and torch. This means you can still use the 4 backends (numpy, torch, jax and tensorflow) to define your loss function but for jax and tensorflow, operations on the manifold are still performed with numpy. For Pytorch, all operations are performed with Pytorch and there are no more conversions to numpy arrays. The list of available backends for numericals is available at To get an overview of this PR, you can begin with The manifolds are backend agnostic, i.e. they instantiated without specifying the backend of input data. The only case when the manifold must know the backend is when sampling a point with the When running All manifolds are still tested with numpy. When a manifold stores data like in Some modules had to be adapted such as Overall, most of the remaining work concerns the tests of all manifolds except @nkoep, tell me what you think about all of this! |
WIP: Add numerics functions
This PR follows #252