Adjust the SwiftUI LCP dialog #611
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mickael-menu
commented
Jun 12, 2025
mickael-menu
commented
There was a problem hiding this comment.
Pull Request Overview
This PR adjusts the LCP dialog in the SwiftUI interface by refining its text components and layout. Key changes include:
- Removal of the "forgotYourPassphrase.help" localized string from the English localization file.
- Updates to the LCPDialog view including removal of explicit spacing and help text within a DisclosureGroup.
- Reorganization of the footer hint display to enhance UI consistency.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Sources/LCP/Resources/en.lproj/Localizable.strings | Removed an unused localized string key to match updated UI requirements. |
| Sources/LCP/Authentications/LCPDialog.swift | Modified layout in the DisclosureGroup by removing spacing parameters and help text, and repositioned the footer hint. |
Comments suppressed due to low confidence (3)
Sources/LCP/Resources/en.lproj/Localizable.strings:12
- Removal of the 'forgotYourPassphrase.help' localized string suggests corresponding UI changes. Please confirm that there are no remaining references to this key elsewhere in the UI.
"ReadiumLCP.dialog.forgotYourPassphrase.help" = "Forgot your passphrase? Use the button below to request a new one from your library or bookstore.";
Sources/LCP/Authentications/LCPDialog.swift:159
- [nitpick] The removal of the help text for forgotten passphrases may impact user guidance. Confirm that this change was intentional and that the updated user flow still provides adequate assistance.
- Text(ReadiumLCPLocalizedStringKey("dialog.forgotYourPassphrase.help"))
Sources/LCP/Authentications/LCPDialog.swift:153
- Changing from 'VStack(spacing: 16)' to 'VStack' may affect the intended layout spacing. Please verify that using the default spacing aligns with design requirements.
VStack {
HadrienGardeur
approved these changes
Jun 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.