Make GSON and org.json dependencies optional #3278
Conversation
Stop requiring GSON and org.json dependencies by decalring them 'optional' in the pom file as described in https://maven.apache.org/guides/introduction/introduction-to-optional-and-excludes-dependencies.html This change will break existing projects that use the JSON jedis feature and don't have explict depedencies to GSON and org.json. Projects that don't use JSON would not longer have unwanted dependencies in their classpath
Codecov ReportBase: 66.94% // Head: 66.89% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #3278 +/- ##
============================================
- Coverage 66.94% 66.89% -0.05%
+ Complexity 4635 4632 -3
============================================
Files 256 256
Lines 15014 15014
Branches 937 937
============================================
- Hits 10051 10044 -7
- Misses 4560 4565 +5
- Partials 403 405 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
This is unlikely to be accepted, for the reasons mentioned in the description. Advanced and concerned users can now exclude those dependencies. |
Alright. Perhaps it can be accepted for the next major version if the JSON support remains implemented in the same way. |
sazzad16
added
the
breakingchange
Stop requiring GSON and org.json dependencies by declaring them 'optional' in the pom file as described in https://maven.apache.org/guides/introduction/introduction-to-optional-and-excludes-dependencies.html
This change will break existing projects that use the JSON jedis feature and don't have explicit dependencies to GSON and org.json. Projects that don't use JSON would not longer have unwanted dependencies in their class-path
See #2961 and #2962 for more information and rationale.