Update symfony from 5.3 to 5.4 #543
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Call to deprecated method isAuthenticated() of class Symfony\Component\Security\Core\Authentication\Token\TokenInterface:
since Symfony 5.4, return null from "getUser()" instead when a token is not authenticated
Codecov Report
@@ Coverage Diff @@
## master #543 +/- ##
=========================================
Coverage 99.33% 99.33%
Complexity 1893 1893
=========================================
Files 301 301
Lines 5996 6013 +17
=========================================
+ Hits 5956 5973 +17
Misses 40 40
Continue to review full report at Codecov.
|
|
PHPUnit is ✅ was also able to do some stuff locally on my development machine. So I suspect this PR is fine 👍 |
akondas
reviewed
Jan 7, 2022
akondas
approved these changes
Jan 7, 2022
|
@akondas pushed the last change to address your comment, all should be fine now :) |
|
Thanks @xvilo 🍻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Active support for Symfony 5.3 ended 6 days ago (01 Jan 2022). Symfony 5.4 was released 1 month and 1 week ago (29 Nov 2021) and it's support ends in 2 years and 10 months (30 Nov 2024).