-
-
Notifications
You must be signed in to change notification settings - Fork 544
4987 annual report across years, implementation and unit tests #5199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
4987 annual report across years, implementation and unit tests #5199
Conversation
maintainers, please let me know if I need to change anything. I will update the user documentation later. |
@alexwitedja: Initial functional checks look good. I'm going to want to test this against production data, but also passing it on to @dorner for technical checks. |
@alexwitedja When I tested against production data, I'm seeing some anomalies. They may well be pre-existing, but I want to investigate further to find out what's going on. (Edit: The anomalies are enough that we might as well hold off on @dorner checking this until I'm done. Go ahead with the user guide update, though, please -- they shouldn't affect that.) |
I'm at the end of my time on this for today -- So far, I'm seeing that there is a a difference between what is coming out for Cloth diapers distributed for some of the earlier years between what happens on an export of the individual year, and what is in the export that goes over all the years. I suspect there is something year-specific in the existing code. (This does not surprise us at all -- it's probably why we ranked this as "intermediate" rather than beginner. ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is going to be a heavier introduction to the system than you may have anticipated!
Looking at the results I get when I do an export with data going all the way back to 2018 -- it appears that the export for each year has different columns.
What we're going to need for this export is the same columns for each year .
If we don't calculate a value for a particular column for a given year, please put "N/A" in the cell. That's a "nice to have" -- I expect we could work with them being empty.
Hey @alexwitedja - Are you still working on this? |
Resolves #4987
Description
Type of change
How Has This Been Tested?
Screenshots