feat: Allow to cancel request when partner is deactivated #5233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- modify RequestDestroyService to not return false on validation for deactivated partners - add condition to not send email when partner is deactivated
|
I am keeping it in draft for now because I would like to receive answers for few questions asked under the ticket. :) When it will be clear I will adjust rest and make it ready. |
…il if partner is not active - fix typo on "cancelation" - add more space between button and text - replace span with div to keep block structure
|
@zanetagebka The test that is failing appears to be related to your change. |
|
The manual functional test passes, though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5231
Description
List any dependencies that are required for this change. (gems, js libraries, etc.)
Include anything else we should know about. -->
Type of change
How Has This Been Tested?
Added test for service to chek that in case of deactivated partner action is running WITHOUT sending an email.
Instruction for manual testing are already in the ticket description.
Screenshots